http://qa.drupal.org/pifr/test/20036 should have failed, but didn't because the tests in ajax.test didn't run: neither the ones that exist in HEAD without the patch, nor the one that was added by the patch.

The patch submitted afterwards, http://qa.drupal.org/pifr/test/20042, fixed a bug in the patch, and the AJAX tests did run.

Seems like this is a really critical problem, as buggy patches can pass bot, land in HEAD, and then cause a broken HEAD.

Comments

boombatower’s picture

boombatower commented
Status: Active » Fixed

This was somewhat hackishly fixed in Drupal core SimpleTest #560646: Fatal PHP errors don't cause tests to fail.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.