The current process for creating a default meta tag seems a bit inefficient. Setting the default meta tag on the admin/content/nodewords/meta-tags page can only be done for meta tags that are checked in the 'Meta tags to show on edit forms' section.

If you are creating default tags, you may not necessarily want to edit them on a page by page basis. However if you want to set a default meta tag, you must currently check the 'Meta tags to show on edit forms' check box for that tag and then edit the default value in the admin/content/nodewords/meta-tags page.

Then you must return to the 'Meta tags to show on edit forms' section and remove the check if you don't want to change it on a page by page basis.

Would it not make more sense for the default meta tags on the admin/content/nodewords/meta-tags page to appear when a tag is checked in the 'Meta tags to output in HTML' section rather than the 'Meta tags to show on edit forms' section?

Jason

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I agree.
The code has been changed because somebody complained that the meta tags form fields where shown in the settings page for the default values, despite the value set for the option Meta tags to output in HTML.

I will change the code to work as it worked before.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 6.x-1.3-beta5 » 6.x-1.x-dev
Status: Active » Fixed

Actually, the code has been already changed.

For the default values, a form field is shown if the relative meta tag has been selected to appear in the forms, or has been selected to be output in the tag HEAD.

    if ($type == NODEWORDS_TYPE_DEFAULT) {
      if (empty($edit_tags[$name]) && empty($head_tags[$name])) {
        continue;
      }
    }

The code has been changed upon request, and it is present in the development shapshot. In less than a week I will create a new official release, which will contain the modified parts already present in the development snapshot.

jasont28’s picture

jasont28 commented

Thank you KiamLaLuno, that is great news.

On a slightly smaller issue, the 'admin/content/nodewords' page reads "IRCA validation content" for the Family Online Safety Institute text area. The 'IRCA' should read 'ICRA'.

Jason

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Good catch!

Thanks for your help, jasont28. The code has been changed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.