Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
install system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Nov 2009 at 03:42 UTC
Updated:
21 Dec 2009 at 05:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
bleen commentedhere testbot ... here boy
Comment #2
mcjim commentedWhile this patch works (for this form, I haven't checked others), I think this has more to do with the markup free clearing which is applied to all form items.
From reset.css:
As the sidebar is floated right, this CSS stretches the div to clear the height of the sidebar.
If you continue the installation, the form items on the next page are wrapped in fieldsets, so we don't see this issue.
Solutions could include:
div.form-item:afterfrom the above CSSJust off to look at other forms in seven to judge what's going to be affected by any of these changes (I may be some time...)
Comment #3
mcjim commentedHmm. Seven doesn't really have a sidebar, apart from the maintenance page.
Still, perhaps it's safest to just override this style for the maintenance pages:
Doesn't appear to break anything else.
Comment #4
bleen commentedHere Testbot ...
Comment #5
bleen commentedThe patch in #3 works fine in FF3.5 (mac) and Safari 4
Comment #6
bleen commentedand ff3, IE6, IE7, IE8 in vista
Comment #7
webchickWeird. I swear I committed a fix for this problem already. We are probably going to need someone CSS-savvy to go in and take stock of Seven's CSS and do one big clean-up sweep before we turn it into a spiralling horror of nightmares and tears.
bleen18, mcjim, are you game? :)
Anyway, committed to HEAD. Thanks!