This doesn't look right...

Only local images are allowed.

The attached patch fixes it, but I have no way of testing IE on Mac... anyone able to take a look?

CommentFileSizeAuthor
#3 install-css-fix-02.patch560 bytesmcjim
install-css-fix.patch686 bytesbleen
install.jpg23.16 KBbleen

Comments

bleen’s picture

Status: Active » Needs review

here testbot ... here boy

mcjim’s picture

Status: Needs review » Needs work

While this patch works (for this form, I haven't checked others), I think this has more to do with the markup free clearing which is applied to all form items.
From reset.css:

/**
 * Markup free clearing ===============================================
 *
 * Consider adding your own selectors to this instead of finding ways
 * to sneak the clearfix class into Drupal's markup.
 * From http://www.positioniseverything.net/easyclearing.html
 */
div.form-item:after,
ul.links:after,
div.admin-panel .body:after,
.clearfix:after {
  content: ".";
  display: block;
  height: 0;
  clear: both;
  visibility: hidden;
}

As the sidebar is floated right, this CSS stretches the div to clear the height of the sidebar.
If you continue the installation, the form items on the next page are wrapped in fieldsets, so we don't see this issue.

Solutions could include:

  • removing div.form-item:after from the above CSS
  • floating the entire form/content div left
  • wrapping the form items in a fieldset

Just off to look at other forms in seven to judge what's going to be affected by any of these changes (I may be some time...)

mcjim’s picture

StatusFileSize
new560 bytes

Hmm. Seven doesn't really have a sidebar, apart from the maintenance page.

Still, perhaps it's safest to just override this style for the maintenance pages:

body.in-maintenance div.form-item:after {
  content: "";
  display: none;
  clear: none;
}

Doesn't appear to break anything else.

bleen’s picture

Status: Needs work » Needs review

Here Testbot ...

bleen’s picture

The patch in #3 works fine in FF3.5 (mac) and Safari 4

bleen’s picture

Status: Needs review » Reviewed & tested by the community

and ff3, IE6, IE7, IE8 in vista

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Weird. I swear I committed a fix for this problem already. We are probably going to need someone CSS-savvy to go in and take stock of Seven's CSS and do one big clean-up sweep before we turn it into a spiralling horror of nightmares and tears.

bleen18, mcjim, are you game? :)

Anyway, committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.