False positives with CVS checkouts

Internally Hacked! is just applying sha1 to the project files, so using cvs deploy to modify the diffing rules is a bit of a no-go.

I've just written some code that checks out modules from cvs for another project, so I'm going to look at integrating that with Hacked!

I'd imagine I might still depend on cvs deploy to get the branch/tag name and then use my code to download the code. Then we just don't cache the hashes too much and we're away!

I've just committed some code that does now check CVS checkouts too. It needs some work though!

I need to rethink the caching, CVS and download methods need to be cached in different places, hmmm... my 'weekend' module needs some daytime love.

Moving to version 2.x

The module could checkout using both the -r (branch) and -D (date) options, to check out the files from the correct branch and date... calculating the date could be tricky, although if the files originally were begotten via a tar.gz then the date is in the module's .info file.

If the module was itself a CVS checkout (and the control folders/files are in there) there might be another way.

Of course, all the files themselves could also be scanned and just use the latest date found among them.

Thus, inside hacked_cvs_checkout():

exec("cd $checkout_location; $cvs_cmd -z6 -d$cvsroot -q checkout -d $checkout_folder -r $tag $folder", $output_lines, $return_value);

needs to become

exec("cd $checkout_location; $cvs_cmd -z6 -d$cvsroot -q checkout -d $checkout_folder -r $tag -D $date $folder", $output_lines, $return_value);

where $date is the magic date number that needs to be calculated beforehand.

CVS checkouts are now handled much better in 2.x.