theme_simplenews_template_mail() function not being called.

Also affected by this please advise thanks

I have had some success > install simplenews_template then go to admin/content/simplenews/types/edit/xx > go to the Style section > css at the bottom and put in stuff like below
regards

Joe

ul.links.inline {
display:none;
}

.views-admin-links {
display:none;
}

.taxonomy {
display:none;
}
.field-field-image img {
border:0 solid green;
float:right;
margin:4px 0 0 10px;
}

.field-field-image-cache img {
border:0 solid red;
float:right;
margin:4px 0 0 10px;
}

I did not apply the patch entirely, only the following part:

- if (is_null($message['body'])) {
+ if (!is_null($message['body'])) {

That solved the problem for me (theme functions not being overridden)

I was also trying to write my own override for the theme_simplenews_template_mail function and discovered it was not being called.

I found the descriptions of the themeable functions to be very deceiving:

/**
 * Theme function for the actual content.
 */
function theme_simplenews_template_content($newsletter_name, $issue_title, $header, $issue_body, $footer) {

/**
 * Themeable function for the HTML e-mail content.
 * Based on http://www.mailchimp.com/resources/templates/.
 */
function theme_simplenews_template_mail($newsletter_name, $issue_title, $issue_body, $style, $bgcolor) {

At first I though the *_content function would theme the node on the site and the *_mail function would theme the node when emailed. However, now I am under the understanding that the _content function themes the content of the node and the the _mail function puts HTML wrappers around that output when it is mailed.

Also, I was confused by the documentation instructing to use the simplenews_template.tpl.php while there is no such file. Is that file supposed to be available to theme the simplenews nodes on the site?

For clarity, I have changed this title to be more appropriate for the patch that needs review above, and the issue of the missing simplenews_template.tpl.php file should be discussed at #684836: D6.x version has no simplenews_template.tpl.php file..

Also affected by this.

Subscribing, neither #3 nor #5 worked for me.

The new dev release fixes this part of the patch:

- if (is_null($message['body'])) {
+ if (!is_null($message['body'])) {

The other parts are still needed when working with simplenews 6.x-2.x-dev. I attached a new patch. Please review & test!

Subscribing...

I'd love to test, but I have no idea where/how to start/test.

Can anyone provide an example on how to use this function?

function theme_simplenews_template_content($newsletter_name, $issue_title, $header, $issue_body, $footer) {

Where does this function go? In template.php? Do I create a new file called simplenews_template.php and put it in there? Once I have it in the correct file, how do I use it?

Thanks for reading,
-Tim

It's also fixed in latest dev

last commit for 6,x dev is still from July 11, 2010 - 08:07
so this is not fixed

Also affected by this

ok switched the status... No idea why it isn't commited... Just use the patch in the meanwhile...

Any progress on this: is there gonna be an new version soon? Would be great not having to patch