This is so silly that I feel like it must just be my setup somehow, but here is what my event creation dialog looks like: link.

As you can see, the labels for the various fields appear to the right of the fields they are meant to label, making it quite difficult to understand at first glance which field is which. I feel like they should either be above the actual entry widgets (as most forms in the rest of Drupal are) or to the left.

I'm going to work on a patch for this, and I'll post it here once I finish up.

CommentFileSizeAuthor
#12 e.patch2.53 KBm3avrck
#11 Picture 2_2.png16.93 KBm3avrck
#10 Picture 1_8.png17.75 KBm3avrck
#5 event_form.patch3.63 KBbenwei
#4 eventdate.JPG20.5 KBcutesimaus
#3 placement_of_field_titles_screenshot.JPG192.94 KBnetbjarne

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented

I look forward to a patch, the current layout is indeed not good.

benwei’s picture

benwei commented

So after some preliminary work, it looks like the reason this form looks so strange is that the '#description' instead of '#title' keys are being used to label for form elements. Descriptions are supposed to appear below form elements.

I tried just using '#title' in place of '#description', but this is not really an improvement, because the titles are then wrapped in 's, which are treated as blocks, so the form gets laid out vertically.

I will continue to play with this, in the meantime if anyone knows of examples from other modules where forms with a similar layout are generated nicely, posting them here would be a great help.

netbjarne’s picture

netbjarne commented
StatusFileSize
new placement_of_field_titles_screenshot.JPG192.94 KB

Field titles should appear above the fiels, just as it does in the attached screenshot :-)

cutesimaus’s picture

cutesimaus commented
StatusFileSize
new eventdate.JPG20.5 KB

Mine looks bad too.
Please refer to the attachment.

I think its with the template, I am using mollio's..
It's really a pain for the users and I have received a lot of complaints about it..

I am looking into editing event.css but I havent hit the right buttons yet.
Hope somebody can help.

benwei’s picture

benwei commented
Status: Active » Needs review
StatusFileSize
new event_form.patch3.63 KB

A patch is attached.

The solution turned out to be pretty simple, especially when I blatantly stole it from the project module. I just wrapped the fieldsets containing the date selectors in divs with a custom CSS class 'date_selector'. I then added a CSS class to event.css which made elements of class form_item under this float left.

Thanks netbjarne for attaching that screenshot and pointing me towards the project module.

The only issue with this patch is that it does not preserve the ':' between hours and minutes. Nevertheless, I think it is a huge improvement over the previous layout.

To apply:
Download, cd to the modules/event directory and run
patch -p1 <path/to/event_form.patch

Ben

killes@www.drop.org’s picture

killes@www.drop.org commented

Does anybody object to this patch?

gerhard killesreiter’s picture

gerhard killesreiter commented

I received another suggestion: Do away with "hour", "mnute" etc entirely. I think that's a great idea.

benwei’s picture

benwei commented

Gerhard, do you think you could explain this idea a bit more? Do you mean to have a text entry box for the time instead of the dropdown menus?

m3avrck’s picture

m3avrck commented

I will post my new patch soon that makes it even more intuitive. I'm using this interface on a site exclusive for *very non technical* people and it's working well. Patch to follow.

m3avrck’s picture

m3avrck commented
StatusFileSize
new Picture 1_8.png17.75 KB

This is the current, clunky interface.

m3avrck’s picture

m3avrck commented
StatusFileSize
new Picture 2_2.png16.93 KB

Here's the new, cleaner interface.

m3avrck’s picture

m3avrck commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new e.patch2.53 KB

Here's the patch.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)