Closed (fixed)
Project:
Translation Overview
Version:
6.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
25 Nov 2009 at 11:10 UTC
Updated:
12 May 2026 at 14:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drewish commentedAre you familiar with the module_exists() function? it would simplify this patch a bit. Also you're not following the Drupal coding standards for spacing between the if and ( and ) and {. Take a look at the coder module to help identify these issues.
Could you put a comment that domain referes to the domain access module? Actually could you do that on the other part too?
Comment #2
Anonymous (not verified) commentedSorry for the forgotten spaces, it's my speciality
About the module_exists() function, I knew that it exists, but I really don't like how it is coded.
It uses the module_list() wich return the list of all modules installed after having performed a file_exists on every files of every modules (http://api.drupal.org/api/function/module_list/6). I've more than one hundred modules installed so it's far to be efficient.
I just want to know if one module is installed so I just do the necessary.
Comment #3
drewish commentedI'm not persuaded by your argument against using module_exists(). The results are statically cached so it only happens once per request and there's plenty of other places in the code where it's called. We're already calling language_list() which indirectly calls module_exists().
Comment #4
Anonymous (not verified) commentedOk, I agree on that, Thanks for the enlightenment
I post an modified version of the path following your advise
Comment #5
drewish commentedthanks, committed to HEAD.