Title says all, have everyone tested the flag note + flag last versions, because the last time i checked it gave me this error

http://pokit.etf.ba/upload/pokitb8b26f24186191c7af8a25e2cc6115ca.png

CommentFileSizeAuthor
#9 flag_note2.patch1012 bytesgunzip

Comments

vertazzar’s picture

vertazzar commented

http://drupal.org/node/625422

correction ** this error Fatal error: Unsupported operand types in all\modules\flag\flag.module on line 1575

gunzip’s picture

gunzip commented
Assigned: Unassigned » gunzip
Status: Active » Postponed

i'm waiting for the stable flag 6.2 version to make changes. there will be two versions of flag note: 6.1 compatible with flag 1.0 and 6.2
will be the new branch for flag 2. flag note 6.1 is not compatibile with flag version 2 and never will be probably. this because as flag2 changed a lot, hopefully there will be important changes in flag_note 6.2 too (i won't backport new features).

vertazzar’s picture

vertazzar commented

okay, thanks for reply

that0n3guy’s picture

that0n3guy commented

How stable is stable? Beta is out now and seems to be pretty good. I needed it for some access control but would love to have flag notes with it.

gunzip’s picture

gunzip commented

even if i'm the mantainer, i don't use flag modules intensively. it's better to ask this question to the user base which is welcome to provide some feedback.

brisath’s picture

brisath commented

Subscribing.

Flag Notes is perfect for my site, so I would like to be able upgrade Flags and Flag Notes to 2.x

vertazzar’s picture

vertazzar commented

Completely agree with you, also note that flag friend is compatible with flag 2.0 which only remaining module that is *extremely useful to use in arsenal of flag modules* is flag note

ManyNancy’s picture

ManyNancy commented

Subscribe

gunzip’s picture

gunzip commented
Status: Postponed » Needs review
StatusFileSize
new flag_note2.patch1012 bytes

here's a two lines patch that should make flag note compatible with latest beta flag 2.x
i will incorporate this one in the next version of flag note if feedback is good.

brisath’s picture

brisath commented

Thanks for your attention on this. Hopefully someone can test this soon, since I'm not patch-friendly right now. I'll look forward to implementing the next version when it is ready.

vertazzar’s picture

vertazzar commented

the flag_note now do not give error, i tested it (with patch above) and it works fine. but i didnt tested it how it works with views etc. it should work probably.

BenK’s picture

BenK commented

Subscribing....

brisath’s picture

brisath commented

@vertazzar
Thanks for testing the patch. I look forward to trying this in a dev version.

vertazzar’s picture

vertazzar commented

tested everything with flag_note, it works perfectly.

BenK’s picture

BenK commented

Hey everyone,

The patch in #9 works perfectly for me. Gunzip, now that we've had multiple people test it, can we get this patch committed as soon as you have a chance?

Cheers,
Ben

ChaosD’s picture

ChaosD commented

i also can confirm that the patch works fine for me

gunzip’s picture

gunzip commented

the patch is already into the 6.2-dev release in CVS:

cvs -z6 checkout -d flag_note-DRUPAL-6--2 -r DRUPAL-6--2 contributions/modules/flag_note/

i've just created a new release that will appear on the project page soon.

brisath’s picture

brisath commented

Thanks for the recent dev release. I upgraded to this and also Flags 6.2 and everything seems to be working fine in testing for the past several days.

gunzip’s picture

gunzip commented
Status: Needs review » Fixed

thank you for your feedback, i close the issue then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.