Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Issue link: http://drupal.org/node/224333#absolute_includes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | absolute-path-642992.patch | 1.89 KB | babbage |
Comments
Comment #1
babbage commentedHave a patch for this. Testing it, and expect to upload it tomorrow.
Comment #2
babbage commentedAdded tags. Working on Coder Upgrade patches at the DrupalSouth hackfest, at the behest of webchick. :)
Comment #3
babbage commentedPatch attached. Original regex for this issue in Coding Review didn't actually work. The attached patch both corrects that regex, ensures that a warning is not given in situations where the user has already made this upgrade, and adds an automatic upgrade where it is required.
Comment #4
solotandem commentedFixed in next dev release.
dbabbage, thank you for the patch. I implemented this upgrade using the grammar parser, as it is preferred over regular expressions. See coder_upgrade_upgrade_call_alter() in the file coder_upgrade.call.inc.
Correction to review rule still needs to be committed. Added #727724: Use absolute path (constructed from DRUPAL_ROOT) when including a file for the review rule change.