Closed (fixed)
Project:
Coder
Version:
7.x-1.x-dev
Component:
Upgrade Routines
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
25 Nov 2009 at 22:22 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
duellj commentedThis patch address the change by changing the last call to drupal_render to drupal_render_children for each theme_x() function.
It also:
-Changes function parameters from multiple parameters to a single $variables parameter
-Assigns old parameters to corresponding $variables keys
Comment #2
adrian commentedthis actually looks very sensible, but i need to test it when i get to DC before i give you a conclusive answer.
one thing though , it needs to make sure to upgrade the hook_theme , and it needs to also keep track of the arguments -> variables change, and all associated theme() calls need to change to use the keys on single parameter it accepts now.
Comment #3
solotandem commentedThe other changes you mention in your last paragraph should already be happening from the existing upgrade routine. This patch is intended to plug the hole you brought to my attention, namely to change the theme_xxx($var1, $var2, ...) function signature to theme_xxx($array) and add statements to the function body to extract the individual parameters from the array variable, i.e., $var1 = $array('key1'), etc.
Is there something else I am missing that you are looking for?
Comment #4
solotandem commentedImplemented in next dev release, with modifications to routine discussed in IRC with duellj.