Nodewords really need a test suite. Thanks to ilo, the module already has its first test file (see #588946-48: Unable to edit the node meta tags unless the user has permission "administer nodes") I will commit in the next 24-36 hours.
Before committing it, I would like to add some more tests. The first test I can think of is a test of some crucial functions of the module; the other test is the one to verify that the meta tags content is really being indexed from Drupal.

CommentFileSizeAuthor
#9 nodewords-n643556-9.patch7.94 KBdamienmckenna

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The file has been added. ilo will then add more tests that will allow us to be sure changes to the code will not introduce new issues with the already existing code.

This report will be marked as fixed when the file will contain more tests.

hass’s picture

hass commented
Status: Active » Postponed

Do not change any code for 1.3, release! Tests are not important enough. Write them for 3.x or D7, but don't kill more Nodewords installation, please. Get the 1.3 out - now - to stop data loss.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed » Active

The SimpleTest tests do not implicate any code change in the module file, or any file included from that file.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Postponed

The test file has been removed, as it needs to be updated with the recent changes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +v6.x-1.12 blocker

Adding a tag.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Am debating whether we need to hold up an important, and hopefully stable, release for this. DaveReid, any thoughts?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -v6.x-1.12 blocker

While this is super important, I'm going to demote it for now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

De-tagging, will review priorities after the next stable release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Needs work
StatusFileSize
new nodewords-n643556-9.patch7.94 KB

WIP.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +D7 stable release blocker

Tag.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

I am closing this issue, which is for a not supported Drupal version.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned