Hi,

When verbose is "on" but clean URLs are off:

Inserted verbose links point to:
http://drupal-dev.pokersource.info/drupal6/?q=sites/default/files/simple...

While they should point to:
http://drupal-dev.pokersource.info/drupal6/sites/default/files/simpletes...

Feel free to tell me if you need more information.

CommentFileSizeAuthor
#6 643756-simpletest-verbose-cleanurls.patch1.03 KBdave reid
#4 643756-simpletest-verbose-cleanurls-D6.patch1.03 KBdave reid
#3 643756-verbose-link-D6.patch987 bytesboombatower

Comments

proppy’s picture

proppy commented

For your information, this happen with:
Clean URLs: Disabled

boombatower’s picture

boombatower commented
Version: 6.x-2.9 » 7.x-2.x-dev
Assigned: Unassigned » boombatower

Due to:

$this->pass(l(t('Verbose message'), $this->originalFileDirectory . '/simpletest/verbose/' . get_class($this) . '-' . $id . '.html', array('attributes' => array('target' => '_blank'))), 'Debug');

seems l() adds that stuff when it passed it through url.

boombatower’s picture

boombatower commented
Status: Active » Needs review
StatusFileSize
new 643756-verbose-link-D6.patch987 bytes

See if this fixes it for you.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 643756-simpletest-verbose-cleanurls-D6.patch1.03 KB

That's won't work. The only way to get around it is to create the full path so url() thinks its an external link (like using file_create_url() in D6). Patch attached for review from the 6.x-2.x branch.

boombatower’s picture

boombatower commented

queue with bot

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
StatusFileSize
new 643756-simpletest-verbose-cleanurls.patch1.03 KB

Patch without the '-D6' suffix so it can be tested.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

The original report should have been filed against 6.x-2.x. It works just fine in D7.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: bad verbose links » D7 backport: Fix links to verbose messages
Assigned: boombatower » dave reid
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested and committed to CVS! Thanks everyone.
http://drupal.org/cvs?commit=449954

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.