Closed (won't fix)
Project:
FileField
Version:
6.x-3.2
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2009 at 11:19 UTC
Updated:
20 Dec 2009 at 02:26 UTC
Hello,
I have published the slightly modified module content_multigroup for CCK2 that was previously hidden in CCK before version 2.6. I am aware of the ongoing effort with CCK3, but for some of us we can't wait for it and we are using this module, with its inherent design limitations.
I have seen that filefield had code to support this module in the past, but since then it seems it had changed a bit. So uploading a file make everything dissapear.
The following patch fix everything:
+++ filefield.module (revision 3321)
@@ -509,7 +509,9 @@
// Update the cached form with the new element at the right place in the form.
if (module_exists('fieldgroup') && ($group_name = _fieldgroup_field_get_group($type_name, $field_name))) {
- if (isset($form['#multigroups']) && isset($form['#multigroups'][$group_name][$field_name])) {
+ $fieldgroups = fieldgroup_groups($type_name);
+ if ((isset($form['#multigroups']) && isset($form['#multigroups'][$group_name][$field_name])) ||
+ ($fieldgroups[$group_name]['group_type'] == "multigroup")) {
$form_element = $form[$group_name][$delta][$field_name];
}
else {
Thanks!
Comments
Comment #1
quicksketchSomething is not a bug if it's not actually supported. As far as I know the existing code works with CCK 3 and I'm very hesitant to change the code to support a module that essentially amounts to a hack until CCK 3 comes out.
Comment #2
markus_petrux commented@ndeschildre: I think you should try to see if the current state of the Content Multigroup module in CCK3 works for you, and if not, report any issue to the CCK queue. You have never reported anything to that queue, and your fork is going to cause a lot of confusion!
Comment #3
ndeschildre commentedHello,
Basically resuming the discussion here, this release of Content multigroup for CCK2 is not a fork, just the very same Content multigroup included in CCK2.2 minus a feature (DnD reordering) that was buggy. We are not going to develop it beyond that.
To put some background, Content Multigroup is a *huge* feature that is really wanted by people (see this issue). Content multigroup in CCK3 is exactly what we are waiting for. The only problem is that there is no release yet, so we either have to wait... or use Content multigroup in CCK2, with its known limitations by design.
By making this release of Content multigroup, we are only giving people the choice to use it before CCK3 is out.
Comment #4
quicksketchMaking 2 versions of CCK seems like a bad idea. It creates a support nightmare for anyone that experiences bugs, not to mention potential for impossible upgrade paths. FileField won't support anything other than the official version of CCK.
Comment #5
quicksketch