Revision deletion: Warning messages in settings [#643830]

After installing 6.x-1.x-dev (2009-Oct-11), and then visiting the page admin/content/revision_deletion I get the following warning message:

    * warning: array_fill() [function.array-fill]: Number of elements must be positive in /public_html/includes/database.inc on line 253.
    * warning: implode() [function.implode]: Invalid arguments passed in /public_html/includes/database.inc on line 253.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') )' at line 1 query: SELECT COUNT(*) FROM node_revisions r INNER JOIN node n ON r.nid = n.nid WHERE n.nid IN (SELECT r.nid FROM node_revisions r INNER JOIN node n ON r.nid = n.nid AND r.vid <> n.vid WHERE r.timestamp < 1256818456 AND n.type IN() ) in /public_html/sites/all/modules/revision_deletion/revision_deletion.module on line 172.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ) ORDER BY r.nid, r.timestamp DESC LIMIT 0, 20' at line 1 query: SELECT n.title, r.nid, r.vid, r.timestamp, r.uid, r.log, n.type, n.vid AS current, n.status FROM node_revisions r INNER JOIN node n ON r.nid = n.nid WHERE n.nid IN (SELECT r.nid FROM node_revisions r INNER JOIN node n ON r.nid = n.nid AND r.vid <> n.vid WHERE r.timestamp < 1256818456 AND n.type IN() ) ORDER BY r.nid, r.timestamp DESC LIMIT 0, 20 in /public_html/sites/all/modules/revision_deletion/revision_deletion.module on line 172.

I also have the Diff module installed. Will uninstall, and test with 6.x-1.0-rc2

Comments

Comment #1

iantresman commented 26 November 2009 at 12:23

Can confirm this error message with 6.x-1.0-rc2. Will now uninstall the diff module,and try again.

Comment #2

iantresman commented 26 November 2009 at 12:29

Can confirm this error message with the diff module uninstalled.

I am using mySQL 5.0.22. Do I need a more recent version?

Comment #3

danielb commented 11 December 2009 at 06:00

Granted I am using PHP4 and your project page says you do not support it, but I got these errors when trying to visit: ?q=admin/content/revision_deletion

* warning: array_fill() [function.array-fill]: Number of elements must be positive in /srv/www/htdocs/deepend/html/secure/includes/database.inc on line 253.
* warning: implode() [function.implode]: Bad arguments. in /srv/www/htdocs/deepend/html/secure/includes/database.inc on line 253.
* warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at or near ")" LINE 1: ... <> n.vid WHERE r.timestamp < 1258091639 AND n.type IN() ) ^ in /srv/www/htdocs/deepend/html/secure/includes/database.pgsql.inc on line 139.
* user warning: query: SELECT COUNT(*) FROM node_revisions r INNER JOIN node n ON r.nid = n.nid WHERE n.nid IN (SELECT r.nid FROM node_revisions r INNER JOIN node n ON r.nid = n.nid AND r.vid <> n.vid WHERE r.timestamp < 1258091639 AND n.type IN() ) in /srv/www/htdocs/deepend/html/secure/sites/all/modules/revision_deletion/revision_deletion.module on line 172.
* warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at or near ")" LINE 1: ....vid WHERE r.timestamp < 1258091639 AND n.type IN() ) ORDER... ^ in /srv/www/htdocs/deepend/html/secure/includes/database.pgsql.inc on line 139.
* user warning: query: SELECT n.title, r.nid, r.vid, r.timestamp, r.uid, r.log, n.type, n.vid AS current, n.status FROM node_revisions r INNER JOIN node n ON r.nid = n.nid WHERE n.nid IN (SELECT r.nid FROM node_revisions r INNER JOIN node n ON r.nid = n.nid AND r.vid <> n.vid WHERE r.timestamp < 1258091639 AND n.type IN() ) ORDER BY r.nid, r.timestamp DESC LIMIT 20 OFFSET 0 in /srv/www/htdocs/deepend/html/secure/sites/all/modules/revision_deletion/revision_deletion.module on line 172.

Obviously I also use postgres.

Drupal 6.14
PHP 4.4.0
PostgreSQL database 8.2.14

Comment #4

giorgio79 commented 27 June 2010 at 05:12

Version:	6.x-1.x-dev	» 6.x-1.0-rc2
Priority:	Normal	» Critical

Comment #5

giorgio79 commented 27 June 2010 at 05:16

The warning messages went away after I selected a content type in the setting section.

Works well now.

Comment #6

rdeboer

Melbourne

commented 14 July 2010 at 12:15

Priority:

Critical

» Minor

Same experience as #1, #3, #5 with Revision Deletion version 6.x-1.0-rc2. Diff module NOT installed.

Pressing "Save configuration" on the Administer >> Content management >> Revisions to Mass Delete >> Settings page, resulted in the error messages disappearing and the module operating as expected.

Therefore I don't think this is a critical bug. Downgrading to minor.