Tim_O [timo]

CVS edit link for Tim_O

I have been submitting patch-files to different projects issues for a while now. I then attempted to implement chess-playing using the chess module (http://drupal.org/project/chess), which has only initially been ported to D6. As development on the module is currently stalled (see #635268: Any further work done? Intentions for release?) and the development snapshot available doesn't allow to play properly yet (certain move is not allowed), I started looking into the code, with the intention to provide a patch as I am used to. But by now I have come up with quite some stuff:
* Castle-Functionality
-- Identifies and allows castle-move (checks that neither piece has been moved before and that there is nothing inbetween)
-- Castle-Undo
* Node-View
-- Display of the board with 44x44 pixel
-- Recent Moves (configurable by admin)
-- Move-/Undo-Form when applicable, the former blocks for these are gone
* Random-Chess-Block
-- the block-display for a chessboard is now available as "random chess game"-block and includes recent moves (configurable by admin)
* Outstanding-Moves-Block
-- show all running games in which the viewer is up for a move
* Last-Move-Highlighting in block- and node-view (via CSS)
* Extension and clean-up of the admin-form
-- moved long texts from title to description
-- added different settings for node vs. block-display, in this renamed the variables (should be ok without "migration"-script - they still start with chess_ and will get deleted by the chess_*-delete within the uninstall?)
* Included a CSS-file
* Included Views-Integration (this is merely tested and probably uncomplete)
* Various changes to make the code more readable (especially Multi-Line-SQLs, added comments but also spaces and stuff) - this was mostly to address my own learning-needs

As things usually are, this is not perfect yet. ToDo's within these changes:
* I haven't implemented the check for the "chess-condition" (i.e. king is in chess, etc.) which is needed to fully decide whether a castle-move is allowed or not. So castle moves are possible now, but may be possible although not allowed according to rules in certain conditions (the other player can still check this though and at least you can make that move now).
* Need to check the access within the random-chess block is according to http://drupal.org/writing-secure-code - I used a loop to load all nodes to check access-rights, I think rewrite_sql does something similar?

Now this is lots of stuff and a patch-file isn't really usefull as I changed so much. Also it's hard to make different patch-files, as these would all depend on each other then. To clarify how to go on I contacted the maintainer (http://drupal.org/user/269963). As I think I understand the whole module by now, I offered to co-maintain the project. This would allow me to prepare for a release version while the maintainer hasn't got the time. In his reply he stated that he likes the idea and that I should get back to him when I have a CVS account. So (you might have guessed) I am here to apply for a CVS account - unfortunately without an issue to link to.

Now as I understood the process, you want to have some code to look into, right? Therefore I will post "my" version of the file together with the additional files (the CSS has no comments, but should be self-explaining on the other hand) as a self-reply here. If you want confirmation by EoinBailey, you will have to contact him, sry for not having done this in an issue.

And last, but not least: Thank you for doing this for us and in particular for taking the time to read all the stuff I am writing ;)