FieldAttachTestCase cannot be reused

Right. The real solution would be #610072: setUp() function accepting array as arguments, though. The way setUp() currently uses its arguments is really not handy.

This solution isn't quite elegant, IMO but I guess it does the trick.

This solution isn't quite elegant

Fully agreed - that's why I think the change linked in #2 is the way forward. It's already been committed to simpletest contrib 7 branch (I'm not sure what's the status of this wrt D7 core's simpletest module). API change, though.

Hm. I personally lean towards won't fix on this, and tackling #610072: setUp() function accepting array as arguments instead. We should be able to make it accept either a string or an array, for backwards compatibility.

re webchick: this is a problem we already faced before, and this exact same code is already in FieldTestCase::setUp(), so while I agree that #610072: setUp() function accepting array as arguments is the way forward, committing this meanwhile doesn't add uglyness that's not already in :-/.

too late for the other issue. sorry.

Ok fair enough. But let's at least leave a one-liner or so explaining why we are doing it this way.

This gets even worse with PHP 5.3 in the mix - see chx's #709346: Field tests are broken in 5.3 and can not be extended

Moved chx's patch over here, and added the comment webchick asked for in #9. And back to RTBC.

That PHP 5.3 subtlety, and the code duplication involved for any test that wants to be subclassable, makes it really unfortunate that this is not being fixed by #610072: setUp() function accepting array as arguments, though...

Would #610072: setUp() function accepting array as arguments be acceptable if setUp() could handle both a variable number of strings OR one single array of strings ?
I doubt the code would be so ugly as the one we're adding here...

[edit: actually, that's exactly webchick's proposal in comment #5, which chx crossed as 'too late' (the irony...) - I really think we should reconsider that]

Yes, I would really very much rather change the function signature of setUp() in a fully backwards-compatible way than commit complete cruft like this. No offense. ;)

But I don't understand the PHP 5.3.0 hunks and why the other issue is going to fix those. Help?

The other issue helps because then you can call parent::setup($modules) without needing a dynamic call which is not easy.

And PHP 5.3 needs specific code for dynamic calls to parent::setup($modules) :
http://www.php.net/manual/en/function.call-user-func-array.php#93744

I agree with webchick in #12. :)

Ok, great. :) Let's reconvene in #610072: setUp() function accepting array as arguments.