I haven't seen any issues with it, but I thought I might mention it. The function domain_views_access() could be confused for being an implementation of hook_access(), which it isn't.

This might be a non-issue, I just came by this function trying to fix an issue I'm having with domain_views.

Comments

nonsie’s picture

Perhaps renaming it to something like domain_views_views_access is in order?

agentrickard’s picture

Project: Domain » Domain Views
Version: 6.x-2.0 »
Component: - Domain Views » Code

This is not a problem for D6. hook_access() only calls module that define a node type.

Does Views require this naming convention? (It does in the plugin.)

We should probably clean this up in D7. Normally I call these function _check() instead of _access().

agentrickard’s picture

Version: » 7.x-1.x-dev
Status: Active » Closed (won't fix)

hook_access() is gone in D7, so this can stay as is.