My patch makes Recepient of Send e-mail action equal to '%autor' by default (you set it in 100% cases by hands) and hides this field from the form (turns it to 'hidden').

Please, check the patch, hope it'll save ton of man-hours.

CommentFileSizeAuthor
vbo_sender_hidden.patch1.25 KBneochief

Comments

neochief’s picture

neochief commented
Title: Usability improvements for "Send e-main" action » Usability improvements for "Send e-mail" action

Typo in title.

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Needs review » Needs work

Thanks for your patch! While I agree that this is a usability improvement for the send email action, there are a couple of other concerns:
* VBO is meant as a generic engine. I don't want to insert action-specific code in the module.
* The send email action needs many more improvements, e.g. supporting attachments would be a killer feature.
I think a better approach would be to create a new action that can evolve on its own and that I can include in VBO (along with the other actions included here) or that lives in its own module.

neochief’s picture

neochief commented
Status: Needs work » Needs review

I do agree that VBO is generic engine, but what will change if we'll add just another action inside VBO module? It's just the same. And if not VBO, where should we add this feature?

As for me, additional action is overkill. I agree that attachments is great feature, but it should probably provided somewhere else, maybe inside Rules module, it's out of the scope of current issue. We should take care of standard Drupal system action to allow users to use system out of the box without problems.

We can commit this patch "as is" for now, and ease life for people right from the next release. But we can also wait for some other solution (which can take up to a year to appear).

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Needs review » Fixed

Thought about it more: why not! It's a core action anyway and the improvement is substantial. It's committed now. Thanks.

neochief’s picture

neochief commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

caw67’s picture

caw67 commented

did you habe the patch for the 7er version?

bojanz’s picture

bojanz commented

There will be no D7 patch.
The action can be used with any entity type, and we only guess the correct token for users. I don't see a point of a change that narrow.
You can do that change in your own module if it's important for you.

That said, I've discovered that the core action in D7 for sending email is really crappy (and easy to crash with the wrong token) so it might make sense to have an email action in VBO. Depends on Views Send stabilizing soon, I guess.