I am just starting up a site. Trying to get translation issues put away before i get too far. Love the idea of your module. Unfortunately i am not a coder.

I am seeing two bugs when using your module:

1. The link is sending a https:// address instead of a normal http:// address. I can figure out why this would be. Google chokes on it.

2. Some of your icons are broken. (only English is working for me.)

You can see this situation here:
http://gnsidc.org/drupal6/index.php?q=owupdate1

I hope you can fix this. I would love to use it.

Comments

blinkingtwelve’s picture

blinkingtwelve commented
Assigned: Unassigned » blinkingtwelve

@1
If you access your site over SSL (https), this module will point Google to the SSL version. GT does not proxy HTTPS. So, the right thing to do would be to not show the block if the page in question is being accessed over SSL. I'll patch this in soon.
If you want the links to point GT to http, access your site over http. If you access your site over https, the links will point GT to https, which won't work.

@2
Your web server setup (IIS) seems to have some trouble mapping URL-encoded unicode to filenames. If you'd rename your flag image files to contain only ASCII-characters you avoid this issue. See README.txt for info on how to name your files. For instance, rename 02_Français_fr.png to 02_French_fr.png.

blinkingtwelve’s picture

blinkingtwelve commented
Status: Active » Fixed

@1
Fixed in 2.0-beta2.

bgriswold’s picture

bgriswold commented
Version: 6.x-2.0-beta1 » 6.x-2.0-beta2

I have not been using SSL or HTTPS in my site, so I am not sure why this would be a problem.
I have done as you suggest and renamed the flag files.

I downloaded and installed the 2.0 beta 2. Placed it in /sites/all/modules

Activated the module in the modules list and activated it in the Block list.

But it will not show on the site no matter what access level I have.

This might suggest that the module thinks I am accessing via SSL. But all my documents are located in the httpdocs folder and as you can see I am using an http://gnsidc.org address

So I am a bit perplexed.

blinkingtwelve’s picture

blinkingtwelve commented
Title: URL Transfer bug » URL Transfer bug on IIS
Status: Fixed » Active

IIS appears to differ from Apache re the value of $_SERVER['HTTPS'].
Try this gtranslatelinks.module with the fix I put into CVS. Hopefully, you will get your links back on http, and will see no links if you access your site over https (please test).

bgriswold’s picture

bgriswold commented

It now seems to work. It shows on my pages and takes me to Google translate. Now we need a way to escape the google translate window. I seem to get trapped in there with no obvious way out. The translation links disappear when viewed in the Google Translation mode.

Thanks for the improvements!

bgriswold’s picture

bgriswold commented

The Google Translate Links Block does not show up in the Admin area. This is especially a problem when on the blocks page where blocks are assigned. Unlike other blocks it will not appear, even when assigned.

blinkingtwelve’s picture

blinkingtwelve commented
Status: Active » Fixed

@ #5:
Good to see it's working on IIS now.
No, Google does not provide an obvious way out. And all links get rewritten by the Google proxy, so putting in a link back to the original content will not work (Google will rewrite it to point to its servers).

@ #6:
That's advertised functionality (per the README.txt). However, making the block show up as a placeholder on the block configure page may be a good idea. I think I'll work on that.
The issue in the issue title is fixed, so I'm marking this issue fixed. If you want to track the placeholder feature request you'll have to file an actual feature request (separate issues should be tracked separately).

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.