Filter module was required until we rightfully moved the filter_xss* functions from filter.module into common.inc.

In earlier versions of Drupal, some modules also used _filter_autop() to format their help texts. That is also no longer done.

Hence, we do not need to load filter.module during installation, updating, and also not for the maintenance theme page.

It still needs to be required = TRUE, because during normal site operation, other modules are using filter.module's constants and potentially check_markup(). Removing those special cases is one of my goals for D8 though.

Until then, we can remove this needless WTF.

CommentFileSizeAuthor
drupal.filter-module-load.0.patch2.5 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#470632: Move filter_xss*() into common.inc

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

This makes sense to me. No sense in loading a bunch of code you're not using. Marking RTBC since it is a very simple patch and the testing bot liked it.

Do we need to document that _filter_autop() is not available during install/update anymore?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Nice. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Follow-up: #1934772: Filter module is not required, but is marked as required