Closed (fixed)
Project:
Views Bookmark
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 May 2006 at 01:25 UTC
Updated:
30 Jul 2007 at 15:17 UTC
As I upgraded Core Drupal CVS .. Bookmark Links became broken .. according to this #18260 I made some minor changes ..
Greetz,
T.
| Comment | File | Size | Author |
|---|---|---|---|
| views_bookmark.patch_01.txt | 2.71 KB | tomsys |
Comments
Comment #1
quicksketchThanks, I added brackets around the table name in the db_next_id() call. I think the other fixes in this patch have already been implemented in some way.
Comment #2
cog.rusty commentedTalking about db_next_id(), I wonder if the sequence name
'views_bookmarks_vbid'also needs prefix braces like'{views_bookmarks}_vbid'in the .install file and everywhere.At least this is what the core sequences do, probably to accommodate multisites with multiple non-shared tables and with a (necessarily) shared sequences table with rows for each one.
I have noticed that several other modules have been updating to do that.
Comment #3
quicksketchI had already updated the module file with the sequences reference you suggest:
$vbid = db_next_id('{views_bookmarks}_vbid');But looks like I missed a reference in the install file. I've corrected that one too now.
Comment #4
cog.rusty commentedNice.
And sorry for the mess with the code tags. At least I learned that if you reopen them instead of closing them you get smaller and smaller letters.
Comment #5
(not verified) commented