As I upgraded Core Drupal CVS .. Bookmark Links became broken .. according to this #18260 I made some minor changes ..

Greetz,
T.

CommentFileSizeAuthor
views_bookmark.patch_01.txt2.71 KBtomsys

Comments

quicksketch’s picture

Status: Needs review » Fixed

Thanks, I added brackets around the table name in the db_next_id() call. I think the other fixes in this patch have already been implemented in some way.

cog.rusty’s picture

Talking about db_next_id(), I wonder if the sequence name 'views_bookmarks_vbid' also needs prefix braces like '{views_bookmarks}_vbid' in the .install file and everywhere.

At least this is what the core sequences do, probably to accommodate multisites with multiple non-shared tables and with a (necessarily) shared sequences table with rows for each one.

I have noticed that several other modules have been updating to do that.

quicksketch’s picture

I had already updated the module file with the sequences reference you suggest:
$vbid = db_next_id('{views_bookmarks}_vbid');

But looks like I missed a reference in the install file. I've corrected that one too now.

cog.rusty’s picture

Nice.

And sorry for the mess with the code tags. At least I learned that if you reopen them instead of closing them you get smaller and smaller letters.

Anonymous’s picture

Status: Fixed » Closed (fixed)