Currently elaboration message is shown when you try to appove a relationship. However if someone accidently clicks disapprove (or don't remember person's name ) it is easier they may misatkenly disapprove. So the same elaboration message should be shown when you click disapprove link too.

Comments

ajayg’s picture

ajayg commented
Status: Active » Needs review

And here is simple one line patch
In user_relatiosnhip_elaborations.module, function user_relationship_elaborations_form_alter change

from

if ($form['action']['#value'] == 'approve' && !variable_get('user_relationships_elaborations_api_only', FALSE)) {

to

 if ($form['action']['#value'] == (('approve')||('disapprove')) && !variable_get('user_relationships_elaborations_api_only', FALSE)) {
Bilmar’s picture

Bilmar commented

subscribing - interesting as this will allow an explanation for the user's disapproval as well

robby.smith’s picture

robby.smith commented

+1 subscribing

ajayg’s picture

ajayg commented

can someone please review and confirm the patch is working for you?

alex.k’s picture

alex.k commented
Status: Needs review » Needs work

Showing elaboration is a good idea but it needs cleaning up. Since the record is deleted upon disapproval, we need to let the requester know what the elaboration message was, if it was edited. If I just insert the token @elaboration into disapproval message template, I don't get the edited message but only the original that was sent. So the text entered by the requestee doesn't go anywhere. The patch either needs to correct that, or show the elaboration read-only when disapproving so there's no possibility to edit it.