Hi,

Thanks for releasing the latest update for GoogleNews Module.

I have one request.

I have noticed the modules takes up the name of the site to be put as publication name.
However, our SiteName is long and we haven't used it exactly as the name entered in google news.

As the module takes the publication name from the Name of site given in Drupal, we are in a fix.

Can we have an option to set the publication name manually in settings for the module.

Thanks

CommentFileSizeAuthor
#17 googlenews-n645786-17.patch2.99 KBdamienmckenna
#15 d7_port_of_feed_name-645786-15.patch1.54 KBannikaC
#11 gn_taxonomy.module.patch7.67 KBdanmccarey
#10 gn_taxonomy.module.patch7.67 KBdanmccarey
#8 variable_del.patch315 bytesyan
#7 publication_name.patch1.56 KBalexromao
#5 googlenews-publication-name.patch1.1 KBiamer

Comments

spamwelle’s picture

spamwelle commented

this would be great.

subscribing.

gdtechindia’s picture

gdtechindia commented

waiting for the response from developer on the issue.
regards
dhaliwal

mediahackers’s picture

mediahackers commented

Subscribing - getting this in Google WebMaster Tools:

Unexpected publication name
The publication name specified in your Sitemap does not match the publication name we have for your site in our database. Please check that the publication name in your Sitemap exactly matches the publication name displayed for your articles in Google News.

mknapp’s picture

mknapp commented

Subscribing...

There's a bit of chatter about the 'Unexpected publication name' issue in general on google webmaster forums.

Our duct-tape job does the job for now #12. - http://drupal.org/node/625058

iamer’s picture

iamer commented
StatusFileSize
new googlenews-publication-name.patch1.1 KB

Here's a small patch that allows you to override the publication name in the module's settings. By default it uses the current behavior, until it is overridden.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs work

Variables need to be prefixed with the module name and also need to have a corresponding variable_del() in googlenews_uninstall().

alexromao’s picture

alexromao commented
StatusFileSize
new publication_name.patch1.56 KB

Hi,

here is a patch to change the publication name I've made.
In case you decide to leave it to the original sitename just leave it blank.

yan’s picture

yan commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new variable_del.patch315 bytes

#7 works as intented. Here's a patch that adds variable_del() to googlenews_uninstall().

yan’s picture

yan commented

RTBC?

danmccarey’s picture

danmccarey commented
Component: User interface » Code
Status: Reviewed & tested by the community » Active
StatusFileSize
new gn_taxonomy.module.patch7.67 KB

The attached patch allows taxonomy terms (as well as content types) to be selected for generating the site map.

danmccarey’s picture

danmccarey commented
StatusFileSize
new gn_taxonomy.module.patch7.67 KB

Attaching again.

yan’s picture

yan commented

Does #10/11 have anything to dot with this issue?

yan’s picture

yan commented
Version: 6.x-1.4 » 6.x-1.x-dev
Status: Active » Reviewed & tested by the community

I think #7&#8 are rtbc. I don't see what #10&#11 have to do with this issue.

danmccarey’s picture

danmccarey commented

Yes. Sorry. Wrong thread. Please disregard.

annikaC’s picture

annikaC commented
Version: 6.x-1.x-dev » 7.x-1.4
StatusFileSize
new d7_port_of_feed_name-645786-15.patch1.54 KB

I've updated this patch to apply to 7.x-1.4.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

Needs a tiny amount of work, but yes, this is totally worth including.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new googlenews-n645786-17.patch2.99 KB

This is a bit more comprehensive. It changes the settings to indicate that the site name will be automatically used if the publication name field is left blank, has improved logic for outputting the value, and deletes the variable during hook_uninstall.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Patch (to be ported)

Needs to be backported to D6.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Fixed

The D6 version is no longer supported. Sorry folks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.