Inline css should be combined per media type.

CommentFileSizeAuthor
#9 cssinlinemedia.patch3.31 KBcasey
#6 cssinlinemedia.patch1.84 KBcasey
#3 cssinlinemedia.patch1.74 KBcasey
#1 cssinlinemedia.patch2.32 KBcasey
cssinlinemedia.patch2.64 KBcasey

Comments

casey’s picture

casey commented
StatusFileSize
new cssinlinemedia.patch2.32 KB

Wrong patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

casey’s picture

casey commented
StatusFileSize
new cssinlinemedia.patch1.74 KB

grmbl

casey’s picture

casey commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

casey’s picture

casey commented
Status: Needs work » Needs review
StatusFileSize
new cssinlinemedia.patch1.84 KB
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Please add more information so that everybody will understand the whole context. Give an example of the problem and explain what you expect, what happens, and why what happens is wrong.

Subscribing, thanks.

casey’s picture

casey commented 
$css = <<<EOS
body {
  background: drupalblue;
}
EOS;

drupal_add_css($css, 'inline');

$css = <<<EOS
body {
  background: #fff;
}
EOS;

drupal_add_css($css, array('type' => 'inline', 'media' => 'print');

Currently this results in:

<style type="text/css">
body {
  background: drupalblue;
}
body {
  background: #fff;
}
</style>

But it should be:

<style type="text/css">
body {
  background: drupalblue;
}
</style>
<style type="text/css" media="print">
body {
  background: #fff;
}
</style>
casey’s picture

casey commented
StatusFileSize
new cssinlinemedia.patch3.31 KB

Patch with test.

Issue tags: -CSS aggregation

Re-test of cssinlinemedia.patch from comment #9 was requested by casey.

casey’s picture

casey commented

#9: cssinlinemedia.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +CSS aggregation

The last submitted patch, cssinlinemedia.patch, failed testing.

casey’s picture

casey commented
Status: Needs work » Fixed

Looks like we group inline css on their media type since #228818: IE: Stylesheets ignored after 31 link/style tags.

Status: Fixed » Closed (fixed)
Issue tags: -CSS aggregation

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +CSS aggregation

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.