Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.making somebody type
projects[] = foo is lame when they should just be able to type a list of projects, and have 'drush convert makefile' figure it out automagically.
attached patch should accomplish this. totally untested.
| Comment | File | Size | Author |
|---|---|---|---|
| drush_make_project_list.patch | 2.17 KB | hunmonk |
Comments
Comment #1
dwwWhat's the proposed syntax for what this is supposed to support?
I can't tell from reading the patch, nor the issue description.
is exactly how people specify a list of things in D6 and D7 .info files already. I don't see what the problem is.
I'm tempted to "won't fix", but please explain.
Comment #2
dmitrig01 commentedhe wants it to accept a file in the following format
and turn it into
Comment #3
dwwRe-reading the patch, you propose a ".make" file that looks like this?
? I think that's probably more confusing than helpful. drush convert makefile is supposed to take valid .make input and convert it to more specific data. A raw list of project names isn't even close to what drush make supports. I don't think we want to encourage people to put things in .make files that aren't valid .make formatted data at all. The primary use-case for people running drush convert makefile themselves is when they have generic versions and/or 3rd party code in example.make and they want to generate an example-drupalorg.make. They still want example.make to work with drush make, which it would so long as they don't use the --drupal-org switch. If we start telling people to do a raw list of project names, they can no longer run drush make on this ".make" file, which is bad.
That said, please don't confuse what drush convert accepts as input, and what the project_package UI accepts as input. The text area can accept a list of project names, and the submit handler can prepend "projects[] = " to each line that doesn't have that before handing it off to drush convert.
I think this is really won't fix now. Let's solve this UI/UX problem in the form handling in project_package, not here.
Comment #4
dmitrig01 commentedYeah. It is neither hard for a person nor a human to prepend "proejcts[] = " and then run it through.
Comment #5
hunmonk commentedit's also not hard for people to type projects[foo][version] = 1.0, but we accept projects[foo] = 1.0 -- why? because it's a convenient short form.
IMO, there are far more people right now who have no make file at all. that leaves them typing in projects[] = foo for all their projects. sure it's not hard, but it's kind of silly when what they really want is just 'build a .make file with this list of projects'
i fail to see why drush convert makefile is 'supposed' to be anything. what it should be is the most effective tool possible for getting people .make files that they can use on drupal.org. let's not get hung up on the name, but instead focus on creating the best tool and giving it the right name.
Comment #6
hunmonk commenteddww and i briefly discussed this, and agreed to postpone this until we have more important things in place.
dmitri's original suggestion about a 'drush create makefile' command might be the best way to go to avoid confusion with the tool, and we can do auto-detection of the input in the packaging UI and call 'drush convert makefile' or 'drush create makefile' as appropriate.
Comment #7
dmitrig01 commentedi believe this got fixed with drush generate makefile but never got marked as so. feel free to correct me.