Fatal error: Call to undefined function node_example_insert() when saving new node revision [#646350]

My simple patch for edit kaltura node with revisions.
Example for module Scanner (regular expression search and replace fields of nodes).

PS: this is my first patch :) and possible bugs so only for reviews and tests

Comment	File	Size	Author
	revision-kaltura-moj-patch.diff	2.31 KB	6element

Comments

Comment #1

6element commented 30 November 2009 at 02:54

Title:

path revision

» patch revision

Comment #2

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

commented 15 January 2011 at 07:47

Title:	patch revision	» Fatal error: Call to undefined function node_example_insert() when saving new node revision
Version:	6.x-1.4	» 6.x-2.x-dev
Category:	task	» bug
Status:	Needs review	» Needs work
Issue tags:		+Coding standards

Wow, thanks - possibly my favourite issue in this queue so far!

To reproduce: check "Create new revision" before saving any node of type kaltura media node, kaltura media remix or kaltura playlist.

Three of the submodules (kaltura playlist, node kaltura entry, node kaltura mix) contain references to node_example_insert(). All three use it the same way, and appear the modules would attempt to call node_example_insert() (and fatal) when updating on a site with node revisions enabled.

node_example_insert() is defined in the Node Example Module. It won't be present on most sites because it's not a "real" module.

Moving this to 2.x, will review your patch and work on a fix.

How is it this issue hasn't received more noise in the past? That's just wierd.