Gomez_in_the_South [gomezinthesouth]

I totally agree with point 1, but point 2 should really be in the logging and alerts module. I've been working on that feature for a while now, but needs some help.

The previous applications were #558708: Gomez_in_the_South [gomezinthesouth], #547032: Gomez_in_the_South [gomezinthesouth].

As reported in the project page for Logging and alerts:

Email logging and alerts
Allows routing of watchdog messages to various email addresses, based on their severity levels. For example, emergency and critical messages need to go to a pager or mobile phone email address, while debug messages go no where.

IMO, there is an evident overlapping of functionalities.

IMO, the only solution is #2.

Do I need to submit a new application for a CVS account?

Why? This application has never been declined. You would not be able to submit a new application, and there is not any reason to do so.

function sentinel_cron() {  
  $severity_words = watchdog_severity_levels();
  $cron_filters =sentinel_get_msg_filters('cron');   
   
  if (!empty($cron_filters)) {
   foreach ($cron_filters as $filter) {  
    $time = time()-$filter[SENTINEL_F_TIME];
    $last_update = $filter[SENTINEL_F_NEXT_UPDATE];      
    if (time() - $last_update >0 ) {
      $sentinel_cron_where = array();
      $sentinel_cron_where_values = array();
      $q = " SELECT count(*) as num FROM {watchdog}  WHERE ";      
      $message = t("Entries with ");
      if (strlen($filter[SENTINEL_F_TYPE])>0) {
        $sentinel_cron_where[] = "type IN ('%s')  AND ";
        $sentinel_cron_where_values[] = $filter[SENTINEL_F_TYPE];
        $message .= " <br> " . t("type") . ": " . $filter[SENTINEL_F_TYPE] ;
      }
      if (strlen($filter[SENTINEL_F_SEVERITY])>0) {        
        $sentinel_cron_where[] = "severity IN (%s)  AND ";
        $sentinel_cron_where_values[] = $filter[SENTINEL_F_SEVERITY];
        $sev_html = $filter[SENTINEL_F_SEVERITY];
        foreach ($severity_words as $key => $value) {
          $sev_html = str_replace($key, $value, $sev_html);
        }
         $message .= "<br> " . t("severity") . " : ". t($sev_html);  
      }
      if (strlen($filter[SENTINEL_F_USER])>0) {        
         $sentinel_cron_where[] = "uid IN (%s)  AND ";
         $sentinel_cron_where_values[] = $filter[SENTINEL_F_USER];
         $message .= "<br> " . t("user(s)") . " : ". $filter[SENTINEL_F_USER];  
      }
      if (strlen($filter[SENTINEL_F_KEYWORD])>0) {
        $sentinel_cron_where[] = " ( message LIKE \"%%%s%\"  OR  variables LIKE \"%%%s%\" ) AND";       
        $sentinel_cron_where_values[] = $filter[SENTINEL_F_KEYWORD];
        $sentinel_cron_where_values[] = $filter[SENTINEL_F_KEYWORD];        
         $message .= "<br> " .t("Keyword(s)") . " : ". $filter[SENTINEL_F_KEYWORD];  
      }
      if (strlen($filter[SENTINEL_F_RANGE])>2) {
        $range_arr = explode("and", $filter[SENTINEL_F_RANGE]);        
        $sentinel_cron_where[] = "timestamp BETWEEN %d AND %d ";
        $sentinel_cron_where_values[] = $range_arr[0];
        $sentinel_cron_where_values[] = $range_arr[1];      
        $message .= " <br> " . t("Between") ." : ". t(format_date($range_arr[0], 'small'));
        $message .= t("and") . " : ". format_date($range_arr[1], 'small');
      }else {
        $sentinel_cron_where[] = "timestamp < %d ";
        $sentinel_cron_where_values[] = $time;
        $message .= " <br> " . t("Older than") . " : ". format_date($time, 'small');  
      }
      $q = $q . ' ' . implode(' ',  $sentinel_cron_where);     
      $r = db_query(db_rewrite_sql($q), $sentinel_cron_where_values);      
      $results = db_fetch_object($r);
      if ($results->num>0) {
        $message .= "<br> Total number : ". $results->num;
        $query = "DELETE FROM {watchdog} WHERE ";        
        $query = $query .' '. implode(' ',  $sentinel_cron_where);
        
        //providing data for hook_sentinel before clearing
        $q_hook = "SELECT w.wid, w.uid, w.severity, w.type, w.timestamp, w.message, w.variables, w.link, u.name FROM {watchdog} w INNER JOIN {users} u ON w.uid = u.uid WHERE";
         $q_hook = $q_hook . ' ' . implode(' ',  $sentinel_cron_where);
         $res_hook = db_query($q_hook, $sentinel_cron_where_values);
         $entries = array();
         while ( $data_hook = db_fetch_object($res_hook)) {
        
         $entries[]= $data_hook;
         }
         module_invoke_all('sentinel', $entries, count($cron_filters));        
               
        $res = db_query($query, $sentinel_cron_where_values);
        if (db_affected_rows()>0) {
          $n = db_affected_rows();
          watchdog('sentinel', t($message), NULL, $severity = WATCHDOG_NOTICE, NULL);
           $next_update = time()+ $filter[SENTINEL_F_TIME];         
          db_query("UPDATE {sentinel_filters} s set s.next_update = %d  WHERE s.fid = %d", $next_update, $filter[SENTINEL_F_ID]) ;
       }        
      
     }
    }
   }     
  }  
}

The second argument of watchdog() is a not translated string. Rather than concatenating the string that needs to be translated (even if it is translated from watchdog()), the string should use t()-placeholders.

The code should use the Drupal Unicode functions to handle strings.

if (strlen($object->name) <=0) {
      $users[$object->uid] = "Anonymous";
    }

The length of a string cannot be negative; the string Anonymous needs to be translated.

There have not been replies in the last week. I am marking this application as won't fix.