Does anyone have commit right for this module?
The official maintainer doesn't seem to have been active on this module for a year.
Many patches have been suplied but none committed...

(and, no, right now I cannot take over the maintainership, though I would be willing to supply/test patches if they get committed).

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Someone must be maintaining it. It works with 4.7 and that hasn't been out for that long. Looks like the CVS has a fairly recent version as well.

Michelle

beginner’s picture

beginner commented

No, If you look closer, you'll notice that

1- the official maintainer hasn't committed anything in a year.
2- the 4.7 port has been made last November by Drumm on the the maintainer's behalf
3- all recent cvs commits are done by translators.
4- numerous submitted patches fixing small issues are not being committed.

More importantly, a recent otherwise positive change in cvs commit policies, prevents people with cvs access other that the maintainer from committing patches (the exception being translations). It means that the only person able to commit patches now is not doing it.

Again, I cannot accept the maintainership at this time, but I would be happy to help clean the backlog of issues if someone can commit patches.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Ah, I didn't look that close. I just know I'm using it on 4.7 with no problems, so I knew _someone_ had to have touched it in the last year. :)

You might want to talk to the maintainer of flatforum as privatemessage is relative to this thread:

http://drupal.org/node/62867

Michelle

revival’s picture

revival commented

Yep, I agree -- can someone take over this module? It's an important one for Drupal, and the current version just doesn't work with my setup, but the CVS _should_ -- although of course, no-one is committing the patches.

So if someone could take it over, it would help many many people.

Thanks

R

Boinng’s picture

Boinng commented

I just want to second everything said here - this is an essential module for many sites and to be honest, as a Drupal newbie, I'm surprised it's not part of the core. To find it in such a shambles is a real shame, and at the moment this module is really letting my newly Drupallised site down. Can someone please start committing the fixes already on here, so perhaps we can then concentrate on the very real bugs which are still plaguing it at the moment?

Bèr Kessels’s picture

Bèr Kessels commented
Assigned: Unassigned » Bèr Kessels

I can take over, if people agree, please leave a message here.

I dont have a lot of time, but I am using it, and I did make a LOT of improvements lately, because of the buggy state, committing each improvement into the issue queue is far too much work now. Also: I changed some conceptual stuff, which might not be approved by the maintainer.

What I *do* want to do, is give it a bit more love and approve some more developers to commit.

Bèr

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

+1 from me for you taking it over. It's working fine for me, but improvements are always great. :)

Michelle

rszrama’s picture

rszrama commented

I'd be happy to see you maintain the project and happy to help with commits as well if you desire. Perhaps between our two schedules this can be cleaned up. I'd love to grab a copy of the work you've done if possible until we can get it committed. (You can reach me through my contact form if that's a possibility!)

revival’s picture

revival commented

+1 for you taking it over. Many thanks.

dziemecki’s picture

dziemecki commented
Title: Is this module being maintained? » Please take it

You the man, Bèr.

I'd be willing to pitch in (a little) if you need some help.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Title: Please take it » Is this module being maintained?

Just changing the title back to what it was.

beginner’s picture

beginner commented
Also: I changed some conceptual stuff, which might not be approved by the maintainer.

That's the point of this issue: there's no maintainer to approve or disapprove of anything and nothing can be committed to cvs.
If you officially take over the module (write to the dev list), then you call the shots.

Apparently, a few people are willing to provide bug fixes and review patches (I cannot help until the end of next week, but I'll keep an eye on this module to help as soon as I can, if patches start to get committed again).

Which way do you want to go next?
1) commit everything you've got en masse and then sort out what bugs are still valid?
or
2) first clean the patch queue and commit all bug fixes so that we have a bugfree 4.7 release out soon and THEN apply your changes.

you decide.

BTW: what are your 'conceptual changes'? ;)

mindless’s picture

mindless commented

Hi Bèr/everyone-
I don't want to maintain this module, but I have put in the effort to collect all pending patches and fix a couple more bugs.. see 67612. I hope this can be committed as a starting point for future changes/fixes.. I'm happy to commit it myself if I can get cvs access for this module.

coupet’s picture

coupet commented

mindless, excellent effort, great you have time to commit as required. may need to request cvs account.

privatemsg.mysql and privatemsg.pgsql should also be converted to privatemsg.install

Agree that commit to cvs should be done urgently.

mindless’s picture

mindless commented

Yup, I have a cvs account, just need access for this module granted.. http://drupal.org/node/3279/cvs-access

mindless’s picture

mindless commented

I got CVS access and committed my changes.. my work is done :-)

coupet’s picture

coupet commented

great! think we might need privatemsg.install file?

mindless’s picture

mindless commented

okok, i did that too.. please try it out.

beginner’s picture

beginner commented

What happenned to Ber?

@mindless: thank you very much on your recent commits. Well done!
As promissed several times, if someone can commit patches, I am willing to help (a little) clearing the patch queue.
I have reviewed all issues that were marked "RTBC" or "Patch Needs Review". I have reverted a few to lower states, and updated the patch for others.

Can you now review the following list of issues who were all reviewed by me today:
http://drupal.org/project/issues?projects=3279&states=8,14
(only 3 issues at this time).
Please comment or commit as you see fit.

Thanks.

mindless’s picture

mindless commented
Status: Active » Closed (fixed)