SQL error, if mini panel name over 32 characters

Checked in a max length value on the name property. Thanks for the report!

This happened today with D7. The mini panel name column in the DB is set to 255, but block delta is only 32. Happened after cloning a clone of a clone.

Using Drupal 7.4 & Panels 7.x-3.0-alpha3 on CentoOS 5 and Apache 2.2.3. Received the following error when attempting to clear the cash using drush:

WD php: PDOException: SQLSTATE[22001]: String data, right truncated: 1406 Data too   [error]
long for column 'delta' at row 1: INSERT INTO {block} (module, delta, theme, status,
weight, region, pages, cache) VALUES (:db_insert_placeholder_0,
:db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3,
:db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6,
:db_insert_placeholder_7); Array
(
    [:db_insert_placeholder_0] => panels_mini
    [:db_insert_placeholder_1] => vetrinary_compounding_megameu_content
    [:db_insert_placeholder_2] => bartik
    [:db_insert_placeholder_3] => 0
    [:db_insert_placeholder_4] => 0
    [:db_insert_placeholder_5] => -1
    [:db_insert_placeholder_6] => 
    [:db_insert_placeholder_7] => -1
)
 in drupal_write_record() (line 6859 of /var/www/html/includes/common.inc).
WD php: Warning: Cannot modify header information - headers already sent by (output  [warning]
started at /usr/local/lib/drush/includes/drush.inc:922) in drupal_send_headers()
(line 1039 of /var/www/html/includes/bootstrap.inc).
PDOException: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'delta' at row 1: INSERT INTO {block} (module, delta, theme, status, weight, region, pages, cache) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7); Array
(
    [:db_insert_placeholder_0] => panels_mini
    [:db_insert_placeholder_1] => vetrinary_compounding_megameu_content
    [:db_insert_placeholder_2] => bartik
    [:db_insert_placeholder_3] => 0
    [:db_insert_placeholder_4] => 0
    [:db_insert_placeholder_5] => -1
    [:db_insert_placeholder_6] => 
    [:db_insert_placeholder_7] => -1
)
 in drupal_write_record() (line 6859 of /var/www/html/includes/common.inc).
Drush command terminated abnormally due to an unrecoverable error.

Deleted and recreated the mini panel with a shorter machine name (i.e. - 'delta') as a workaround.

I also had this issue today - I increased the length of the column in the block table as a temporary work around.

I've also encountered the fatal PDO error: String data, right truncated: 1406 Data too long for column 'delta' at row 1

When I clear the cache and I have a mini-panel with a machine name that's longer than 32 characters.

I was able to recover from it by cloning the offending mini-panel and setting the clone to have a shorter machie name, then deleting the original one with the long name.

Seems we're missing that max length index on the machine name, at least for mini-panels in the current alpha!

This is related to #956394: Database column not large enough making it impossible to assign a layout to a panels page, but this time in the opposite direction - allowing minipanels with names longer than 32 varchars will cause problems for the internal Block system.

Thank you for helping me resolve this issue -- it was a problem with a mini panel whose machine name was very very long. Ive recreated it!

Could this not be resolved by not copying the old machine name when cloning - or perhaps enlarging the "edit" text, or maybe its just my eyes which are failing? To emphasise, I couldn't see that the field was editable and got caught by clone of a clone etc.

@merlinofchaos Has the maxlength perhaps just gone missing from D7? Is that still the solution? I'll roll a patch if that's the case.

This issue just struck me while building some minipanels.
In my scenario it would have been good to have a limited on the machine name as the resulting error was very unhelpful.

We increased delta to 64 chars to work around.

Please fix :)

I believe this is fixed thanks to #956394: Database column not large enough making it impossible to assign a layout to a panels page? Anyone care to test it?

Yes I think the maxlength has disappeared due to the conversion to export ui. This may not be a simple patch. This is annoying.

Ok. So one reason to limit the names to 32 characters is that the core Block module won't allow a block delta longer than that, so you wouldn't be able to place the minipanel using block rules and in fact it may give an error if you happen to save the Block page at all (not confirmed). Just something to be aware of.

Yeah.

We could go the route Views did and keep a hash so we can keep deltas short enough if necessary. That'd remove the need to fix the names, but of course it'll have the same problem Views has of totally wrecking your deltas if your names are too long.

Definitely an issue with cloning of a mini panel. It's biting us like mad right now.

Have to wind up changing block table to 64 chars, and/or force renaming the clone's machine name to stop the errors coming out.

Seems like this can be trapped just on the machine name creation for the mini panel name. truncate as necessary and if dupe name, truncate shorter and do a _1 _2 or something?

this is a major issue for us, any fix in the pipeline?

rgds Dave

Really? You can't just make sure your mini panel names are under 32 characters? I realize it's a bug and all, but there's an obvious workaround.

I believe it prefixes stuff and you don't realize it until too late; and once it is in the database it is broken without manual database surgery. At least in my experience.

I ran into this issue as well, worth fixing IMO. Patch attached for review. Works for Me (TM).

Personally, I would not do:

$form['info']['name']['#description'] .= t(' The machine name length is limited to 32 characters, due to a limitation in the core block system.');

but:

$form['info']['name']['#description'] .= ' ' . t('The machine name length is limited to 32 characters, due to a limitation in the core block system.');

In that way, the translatable string doesn't start with a space, which is nicer. Apart from that, it works fine.

Like the patch, I am using it to prevent site users who are unaware of this issue from regularly breaking cache clearing and update.php by adding yet another mini panel that causes this issue.

Patch still applies cleanly.

I'd prefer a solution that goes to the core of the problem... but any port in a storm.

re-roll incorporating the suggestion in #22 - imo it's not a big enough change to warrant changing back to needs review...

Committed and pushed. Thanks for the patch!

Just wanted to give you a heads up that the patch #24 is missing in 7.x-3.3

I just had this happen again after updating the module.

The release date of 7.x-3.3 is in 2012. The patch in #24 is dated 2013.

I believe this should adequately explain why 7.x-3.3 doesn't contain this patch.

This is still happening in panels 3.3

Screen shot

pwaterz: Please read #28.

haha woops, early morning!

This patch solves the problem on 6.x-3.9

Hi All,

I have a client who needs me to finish up some work today so I have limited time to share right now.

I'll try to provide a patch when I finally get some sleep but for now, to work around the issue, I've created a custom module which alters the form to show a message and adds a validation function which prevents the form from being submitted if the machine name exceeds 32 characters.

/**
 * Implements hook_form_FORM_ID_alter().
 */
function examplemodulename_form_ctools_export_ui_edit_item_wizard_form_alter(&$form, &$form_state, $form_id) {
  switch ($form_state['plugin']['schema']) {
    case 'panels_mini':
      $form['#validate'][] = '_examplemodulename_ctools_export_ui_edit_item_wizard_form_validate';
      $desc .= t('The machine name should be kept under 32 characters to avoid problems with other modules.');
      $form['info']['name']['#description'] .= "<br /><strong>$desc</strong>";
      $form['info']['admin_title']['#description'] .= "<br /><strong>$desc</strong>";
      break;
  }
}

/**
 * Validates the ctools export ui form for mini panels.
 */
function _examplemodulename_ctools_export_ui_edit_item_wizard_form_validate(&$form, &$form_state) {
  switch ($form_state['plugin']['schema']) {
    case 'panels_mini':
      if (strlen($form_state['values']['name']) > 32) {
        form_set_error('name', t('The machine name should be kept under 32 characters to avoid problems with other modules.'));
      }
      break;
  }
}

Cheers,
Jeff

This patch is the same as #33 but with proper file paths.