Note I mention this is a support request but I'm sure it is a bug so I'll add to the bug queue.

admin/reports/bawstats/details/%/%/% is the 'others' link at the bottom of the summary sections. This gives the full list of say, the hosts. The title for these details pages is always other access. This is because in bawstats module the menu for details is

  // the "other" more specific things we don't have menus for!
  $items['admin/reports/bawstats/details/%/%/%'] = array(
    'title' => $group_details,

This follows a foreach to set the tabs. The foreach uses $group_details as the tab name hence all details pages have a title of the last tab name. I'm guessing this has been copied and then never corrected. If it was going to be overwritten somewhere then null, or text would have be used. For now I have patch in a drupal approach and used title callback give a better title. Really it needs to look up a better string. My change is:

  // the "other" more specific things we don't have menus for!
  $items['admin/reports/bawstats/details/%/%/%'] = array(
    'title arguments' => array(4),
    'title callback' => 'bawstats_details_title',
    'type' => MENU_CALLBACK,
    'page callback' => 'bawstats_view_theform',
    'page arguments' => array(5,6,4),
    'file' => 'bawstats.stats.inc',
    'file path' => $includes_path,
    'weight' => $pri,
    'access arguments' => array('view site statistics')
  );

  return $items;
}

function bawstats_details_title($section){
  return ucfirst($section);
}

That turns the one word section name to a Title but it really need to use that to look up the section full name. I couldn't see how to get that to work though.

CommentFileSizeAuthor
#4 bawstats-647968-4.patch2.49 KBegfrith

Comments

egfrith’s picture

Thanks for reporting this and working on a solution. I am quite busy at the moment, but I will try to look at it some time soon,

egfrith’s picture

I'm now (after a long, long delay) getting round to looking at this problem. I can see what the issue is, but I'm not yet sure whether the suggestion above is the right way to go.

egfrith’s picture

Assigned: Unassigned » egfrith
egfrith’s picture

StatusFileSize
new2.49 KB

I've now looked at the problem and worked out a fix for it. It involves sanitising the section names (in includes/bawstats.admin.inc) and then iterating over them to make new menus in bawstats.module.

egfrith’s picture

Status: Active » Fixed

This commit has now been made: http://drupalcode.org/project/bawstats.git/commit/85ba62c

Thinking about this issue has prompted another: #1219334: There should be menu tabs on the detailed view pages

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.