Don't move fq params to q.alt if fq params include local params

Posted by jpmckinney on December 1, 2009 at 6:14pm

Issue Summary

In an apachesolr_modify_query hook, I set local params ex and tag for various purposes. Note that I'm not using these local params to do OR faceting, so the special case in the 6.x-2.x branch - if (!$has_or ...) { - is no use.

A more general solution would be preferred. Here's something that would fix the bug for my case and the 6.x-2.x $has_or case, in all versions of apachesolr.

Attachment	Size	Status	Test result	Operations
patch.patch	933 bytes	Ignored: Check issue status.	None	None

Comments

#1

Posted by pwolanin on December 1, 2009 at 6:37pm

Status:

needs review

» needs work

Looks like a bug indeed, but note from php.net re: strstr():

If you only want to determine if a particular needle occurs within haystack , use the faster and less memory intensive function strpos() instead.

Also, should we consider just moving one or more fqs if possible for the performance reasons even if we cannot move all?

In other words we should possibly test each fq, not the imploded list of them?

#2

Posted by jpmckinney on December 2, 2009 at 9:35pm

Status:

needs work

» needs review

Re-rolled to test each fq.

It also omits filter queries starting with '-', as these don't seem to work in q.alt. I discovered this when doing a key-less search with a -language:fr filter using apachesolr 6.x-2.x.