Needs review
Project:
Watcher
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Dec 2009 at 18:35 UTC
Updated:
6 Jan 2011 at 18:23 UTC
Jump to comment: Most recent file
The "x new" links in the watcher binder always point to the first comment page even if the node has comments that span across multiple pages.
The attached patch uses the corresponding comment.module function to calculate the page number of new comments.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | watcher.module.patch | 541 bytes | OV2 |
| watcher.module.patch | 530 bytes | OV2 |
Comments
Comment #1
solipsist commentedThank you. Much appreciated! Will commit this along with a lot of other fixes as soon as I can.
Comment #2
OV2 commentedReroll because of an embarrassing mistake...
It worked, but only due to php's string conversion rules.
Comment #3
solipsist commentedGreat!
When you diff please do "diff -up" instead of just "diff -u". Thanks.
Comment #4
sanguis commentedI just added this patch to my site (6-1.4) and I have not gotten and changes in my output.
Thanx for the patch though. its a starting point