Update weburl with latest CCK hooks [#64827]

Comment	File	Size	Author
#8	weburl_1.patch	11.86 KB	David Lesieur
#3	weburl_update_0.patch	9.31 KB	David Lesieur
	weburl_update.patch	9.25 KB	David Lesieur

Comment #1

coupet commented 22 May 2006 at 14:33

updated to latest weburl cvs then applied patch:

$ patch -p0 -u < weburl_update.patch
patching file weburl.module
patch unexpectedly ends in middle of line
Hunk #2 FAILED at 93.
1 out of 2 hunks FAILED -- saving rejects to file weburl.module.rej

Log in or register to post comments

Comment #2

coupet commented 22 May 2006 at 14:35

patching file weburl.module
patch unexpectedly ends in middle of line
Hunk #2 FAILED at 93.
1 out of 2 hunks FAILED -- saving rejects to file weburl.module.rej

Log in or register to post comments

Comment #3

David Lesieur commented 22 May 2006 at 15:04

Status	File	Size
new	weburl_update_0.patch	9.31 KB

I'm not sure what when wrong... Sorry for that. Here is a re-rolled patch.

Log in or register to post comments

Comment #4

coupet commented 22 May 2006 at 15:14

applied patch, ok; entered 'http://www.google.com' in weburl field; submit and the messages are displayed:

* user warning: Unknown column 'field_web_url_value' in 'field list' query: UPDATE node_content_painting SET field_web_url_value = 'http://www.google.com' WHERE vid = 33 AND nid = 33 in /usr/local/apache/htdocs/sitename.com/dpa/includes/database.mysql.inc on line 120.
* user warning: Unknown column 'field_web_url_value' in 'field list' query: SELECT field_web_url_value AS value FROM node_content_painting WHERE vid = 33 in /usr/local/apache/htdocs/sitename.com/dpa/includes/database.mysql.inc on line 120.

Note: Label is displayed coorectly but the value field is empty.

Log in or register to post comments

Comment #5

David Lesieur commented 22 May 2006 at 15:19

Is that happening with a pre-existing weburl field? There might be an upgrade problem here.

Log in or register to post comments

Comment #6

coupet commented 22 May 2006 at 15:34

yes, is happened with pre-existing weburl field?

I deleted the field and obtain error message (sorry did not record message!) unable to delete web_url_field ?

Created a new Web URL field and works fine.

Log in or register to post comments

Comment #7

David Lesieur commented 22 May 2006 at 16:15

I'll try to fix that in weburl.install. Thanks for the testing!

Log in or register to post comments

Comment #8

David Lesieur commented 23 May 2006 at 22:45

Status	File	Size
new	weburl_1.patch	11.86 KB

Here's a patch that includes both weburl.module and the updated weburl.install. Make sure to backup your db before testing this upgrade. ;-)

Log in or register to post comments

Comment #9

coupet commented 24 May 2006 at 00:18

Applied latest patch weburl_1.patch to cvs weburl.module and weburl.install files.
I had to specify name of files to patch
Works great.

I selected multiple values and can only enter a maximum of 3 URL address.

Unable to add more than 3 URL address.

Log in or register to post comments

Comment #10

David Lesieur commented 24 May 2006 at 16:53

The limit of 3 urls was there before. IMHO it is a separate issue from this one.

Thanks again for the testing! I hope this patch can be committed.

Log in or register to post comments

Comment #11

robertdouglass commented 17 June 2006 at 12:03

Well, since I wrote the weburl filed I guess I should patch it too, eh? =) Will review and get it updated. I've also improved the regexps.

Log in or register to post comments

Comment #12

coupet commented 21 June 2006 at 17:12

ref: cck cvs; weburl.module,v 1.8 2006/06/12 19:36:54

patch result follows:

$ patch -u -p0 < weburl_1.patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /f/projects/drupal/cvs/contributions/modules/cck/weburl.install 2006-05-23 18:38:24.234375000 -0400
|+++ modules/cck/weburl.install 2006-05-23 18:28:19.906250000 -0400
--------------------------
File to patch: weburl.install
patching file weburl.install
can't find file to patch at input line 64
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /f/projects/drupal/cvs/contributions/modules/cck/weburl.module 2006-05-23 18:38:24.343750000 -0400
|+++ modules/cck/weburl.module 2006-05-23 18:28:19.890625000 -0400
--------------------------
File to patch: weburl.module
patching file weburl.module
Hunk #2 FAILED at 93.
1 out of 2 hunks FAILED -- saving rejects to file weburl.module.rej
$

Log in or register to post comments

Comment #13

coupet commented 21 June 2006 at 17:17

try again!
ref: cck cvs; weburl.module,v 1.8 2006/06/12 19:36:54
patch result follows:

$ patch -u -p0 < weburl_1.patch 
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /f/projects/drupal/cvs/contributions/modules/cck/weburl.install    2006-05-23 18:38:24.234375000 -0400
|+++ modules/cck/weburl.install 2006-05-23 18:28:19.906250000 -0400
--------------------------
File to patch: weburl.install
patching file weburl.install
can't find file to patch at input line 64
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /f/projects/drupal/cvs/contributions/modules/cck/weburl.module     2006-05-23 18:38:24.343750000 -0400
|+++ modules/cck/weburl.module  2006-05-23 18:28:19.890625000 -0400
--------------------------
File to patch: weburl.module
patching file weburl.module
Hunk #2 FAILED at 93.
1 out of 2 hunks FAILED -- saving rejects to file weburl.module.rej
$

Log in or register to post comments

Comment #14

treksler commented 17 July 2006 at 16:47

1) always add --dry-run to your patch command to see if there are no errors
2) you need to adjust your -p0 parameter ; try -p5

Log in or register to post comments

Comment #15

David Lesieur commented 18 July 2006 at 05:52

@Robert: Yes, if you could review/update/commit the patch, that would be great! :-)

Log in or register to post comments

Comment #16

marcoBauli commented 23 July 2006 at 11:47

i manually applied the patch:

Fatal error: on upgrade.php i got error related to the "$fields = _content_fields();" on line 40.

Removing the infamous "_" [content_fields();] got the upgrade to proceed.

Warnings: for each of my content-types using the previous weburl field, i get the following:
user warning: Duplicate entry '428' for key 1 query: INSERT INTO node_content_spot (vid, nid, field_url_forecasts_value) SELECT vid, nid, field_weburl FROM node_field_weburl_data WHERE field_name = 'field_url_forecasts' in /home/mysite/public_html/drupal/includes/database.mysql.inc on line 120.

of course when loading a node with a previously filled weburl field a warning is thrown out again:
Unknown column 'field_url_forecasts_value' in 'field list' query: SELECT field_url_forecasts_value AS value FROM node_content_spot WHERE vid = 461 in /home/kiteatla/public_html/drupal/includes/database.mysql.inc on line 120.

Deleting and creating the weburl field again removes the error and shows output, but

No description (help text) in submission form yet...or it's just me?

thx

Log in or register to post comments

Comment #17

David Lesieur commented 20 August 2006 at 23:04

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #18

David Lesieur commented 25 August 2006 at 16:03

Status:

Needs work

» Closed (won't fix)

There is now a link module.

Log in or register to post comments

Update weburl with latest CCK hooks

Comments