Download & Extend

Split out a source_query field from {path_redirect}.source

Project:Path redirect
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

Currently we store all redirect paths (including the query strings) in the source field. I've managed to clean up the code so that it extracts the source_query part out (and converted to an array) and leaves source as the base source path when loading redirects.

I want to look into making source_query it's own serialized text field to store the serialized array to match.

Pros:
- Easy to index on source
- Makes the path loading code simpler since we only need to do a unserialize instead of parsing the path and converting the query string part to an array.

Cons:
- This will make enforcing unique indexes a problem since we need to make sure our unique values would be source, source_query, and language (currently just source and language since the query part is included in the source field).
- Update function is going to be fun to write although I could probably reuse the path_redirect_post_load_redirect function.

Comments

#1

Status:active» closed (won't fix)