Hello

If at all possible, it would be great if the location of the amfphp could be changed to sites/all/libraries so as to not be module nested and therefore overwritten each time the module is updated.

This convention is used to great effect with WYSIWYG module. As an addendum, I was referred to this regarding the same concern with the Printer, e-mail and PDF versions module:

http://drupal.org/node/582104

Thanks very much for a great module,

DDO

Comments

snelson’s picture

Version: 6.x-1.0-beta1 » 6.x-1.x-dev
Component: Miscellaneous » Code
Assigned: Unassigned » snelson
Status: Active » Postponed
Issue tags: +Libraries

Good idea. The issue you posted mentions Libraries API, which will be perfect for this. Postponed until Libraries API reaches a stable release.

snelson’s picture

Title: amfphp Location » Integrate with Libraries API
ClearXS’s picture

Title: Integrate with Libraries API » Integrate with Libraries API & correct path (+ correct version)

Not only for libraries API, but also without it makes sense placing plugins and libraries outside the module in sites/all/libraries and sites/all/plugins. Otherwise I have no way to keep track of inside module libraries from my over 600 modules I'm maintaining on a developers install. New versions are overseen, bug fixes and security holes are overseen, libraries disappear if a new release is installed properly by removing the old module first, etc.

INSTALLATION
------------
- Place entire amfphp folder in the Drupal modules directory, or relevant site module directory
- Download AMFPHP 1.9 beta 2 from You must dowload http://downloads.sourceforge.net/amfphp/amfphp-1.9.beta.20080120.zip?mod...
- Extract AMFPHP 1.9 beta 2 modules/amfphp/amfphp inside of the amfphp module directory
- Enable the module in the admin

=>

I just extracted the 1.9 version from http://sourceforge.net/projects/amfphp/ , not the 1.9 beta2! Suppose this module should be able to work with the final release as that is supposed to be the official release; the better one and often contains bug fixes, instead of beta?

Extracted in the .../modules/amfphp library, then renaming the new folder so I get .../modules/amfphp/amfphp

Thus far so good I guess... But have a lot of additional files and folders; I don't read what to do with them, nor what files are used by this module, so I can throw the others away (some additional remnants can cause a security or performance risk for attacks to plug into them).

I have additional directories in .../modules/amfphp/
* __MACOSX
* overrides

and in .../modules/amfphp/amfphp
* browser (dir)
* core (dir)
* services (dir)
* .DS_Store
* .htaccess
* gateway.php
* globals.php
* json.php
* xmlrpc.php

marcvangend’s picture

Status: Postponed » Active

I agree, sites/all/libraries is the way to go, no need to postpone this on Libraries API.

ASMBL’s picture

Thanks!