Download & Extend
Issues

fix to deter from registration SPAM

Posted by beginner on May 22, 2006 at 12:25pm
Project:Drupal core
Version:x.y.z
Component:user system
Category:bug report
Priority:normal
Assigned:beginner
Status:closed (fixed)

Issue Summary

see full discussion here:
http://drupal.org/node/64861

this simple patch will render registering phony accounts absolutely pointless for spammers.

AttachmentSizeStatusTest resultOperations
registration-spam.diff.txt634 bytesIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by killes@www.drop.org on May 22, 2006 at 5:07pm
Status:needs review» needs work

The patch does not comply with coding standards: We use || not OR.

#2

Posted by beginner on May 23, 2006 at 2:22am
Status:needs work» needs review

new patch.

I see the different precedence between &&, || and AND, OR.
http://www.php.net/manual/en/language.operators.logical.php

Is there any particular (historical) reason why Drupal must use && and || instead of AND and OR?

AttachmentSizeStatusTest resultOperations
spam.diff.txt645 bytesIgnored: Check issue status.NoneNone

#3

Posted by drumm on May 23, 2006 at 3:12am

This doesn't seem to have much to do with "meta roles"; what does this patch do, concisely?

#4

Posted by beginner on May 23, 2006 at 3:17am

the patch is relevant to the discussion about spam registration that I addressed on the 'meta-roles' page:

Any person who has administered a vanilla phpBB2 forum knows that spammers like to register phony accounts, just so that there is a link to their web site in the member list. Drupal has exactly the same flaw as phpBB in that it gives an incentive to spammers to register phony accounts with fake email addresses.

This page removes that incentive, because an account that is never activated (because created by a spammer with a fake email or an email they don't own) is not accessible by anonymous or normal users, and most importantly from the spammers' point of view, the page is not accessible by search engines...

#5

Posted by killes@www.drop.org on May 23, 2006 at 9:40am
Version:4.7.0» x.y.z
Priority:critical» normal
Status:needs review» reviewed & tested by the community

applied to 4.7, downgrading as nothign is that broken.

#6

Posted by beginner on May 23, 2006 at 12:10pm

clean patch for head.

Is there any particular (historical) reason why Drupal must use && and || instead of AND and OR?

AttachmentSizeStatusTest resultOperations
spam.diff_0.txt633 bytesIgnored: Check issue status.NoneNone

#7

Posted by beginner on May 23, 2006 at 12:10pm
Title:4.7 fix for registration SPAM» fix to deter registration SPAM

#8

Posted by beginner on May 23, 2006 at 12:12pm
Title:fix to deter registration SPAM» fix to deter from registration SPAM

#9

Posted by killes@www.drop.org on May 23, 2006 at 12:16pm

We have decided to use && and || and want to keep it consistent.

#10

Posted by beginner on May 23, 2006 at 12:19pm

thanks :)

#11

Posted by drumm on May 24, 2006 at 5:52am
Status:reviewed & tested by the community» fixed

Committed to HEAD.

#12

Posted by Anonymous on June 7, 2006 at 6:00am
Status:fixed» closed (fixed)