Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
I have developed a module, called Invisible Captcha (http://blog.ag-prime.com/2009/06/drupal-captcha-invisible-captcha-challe...) and would like to include it CAPTCHA Pack module.
Please review and see the latest version of my code.
Comment | File | Size | Author |
---|---|---|---|
invisible_captcha.zip | 4.07 KB | gabrielu |
Comments
Comment #1
soxofaan CreditAttribution: soxofaan commentedHi, thanks for your work
I would recommend to contribute the Invisible CAPTCHA module on its own, separate from the CAPTCHA Pack module. The CAPTCHA Pack module already contains a fair amount of sub-modules an this pollutes the admin user interface. I am even considering to slim down the modules in CAPTCHA Pack. I thinks it would be cleaner and easier to offer it as a separate module.
If you don't have the right permissions right now, I could create the project for you if you want.
Anyway, here is some review of the code (I didn't try it out yet, I only read through the code).
invisible_captcha.info
Some typos here: annoying, indecipherable, CAPTCHAs (in capitals)
I would also make the description more clear:
invisible_captcha.module
You seem to be using tabs for indentation, please use 2 spaces as specified in http://drupal.org/coding-standards
What happens when user has no javascript or cookies, I only see a commented line
What is the fall back?
Document why this is needed.
there is
'#id' => 'captcha_response',
, but what happens when there are multiple forms with a CAPTCHA on the same page?I think this documentation does not correspond to the code
This is a lot of duplication from the CAPTCHA module. Can't this be done easier?
in
invisible_captcha_form_alter(&$form, $form_state, $form_id)
you callSo this function is called twice for each form? why is that?
Why is there:
It will never be used as far as I can tell.
script.js
I think this script deserves a better name, why didn't you use 'invisible_captcha.js'?
I didn't have time to dig through the javascript, but it looks there is more code than I would expect
Comment #2
soxofaan CreditAttribution: soxofaan commentedFor extra inspiration: I found this tutorial about a comparable solution: http://docs.jquery.com/Tutorials:Safer_Contact_Forms_Without_CAPTCHAs
Comment #3
gabrielu CreditAttribution: gabrielu commentedHello,
I didn't expect such a detailed review.
You have some pretty good suggestions.
I agree that this would better be a stand-alone project. I will make time to fix the issues.
Thanks for the feedback. I will come back this days with more info / updates.
Comment #4
AlexisWilke CreditAttribution: AlexisWilke commentedHi Gabrielu,
Did you create another project for your CAPTCHA?
I have a version too, that only uses CSS which I think is safer than using JavaScript.
So if you have your own project, we could probably include my version in your project since the CAPTCHA pack author does not want more in his pack (which I don't understand why since these are sub-folders we can delete if we don't want them?!)
Anyway... this was Dec 2009... so that's a while back already!
Thank you.
Alexis Wilke
Comment #5
gabrielu CreditAttribution: gabrielu commentedWell true, I ddin't had the time to take care of this. There isn't any module created yet.
I think we can both make a Invisible captcha, where user could select the method, CSS or Javascript (btw, there are numerous Invisible captcha methods, we could provide some of them, and finally the user could select the most effective one).
We shall discuss.
Comment #6
AlexisWilke CreditAttribution: AlexisWilke commentedAs an FYI, I have created such an option since then:
http://drupal.org/project/hidden_captcha
The Hidden CAPTCHA uses an external CSS for right now, but we may add other features as we move forward.
Thank you.
Alexis Wilke