Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
overlay.module
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2009 at 01:03 UTC
Updated:
19 Dec 2009 at 15:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
mcrittenden commentedSubscribe. Problem was also reported in Chrome (though not sure which version), and I'm seeing it in Midori, so it seems to be a general WebKit thing.
Comment #2
carlos8f commentedI can confirm this issue with Chrome 3.0.195.33 and Safari 4.0.3 (Windows) and Safari 4.0.4 (Mac). Does seem to be general to WebKit.
Comment #3
gábor hojtsyOk, can reproduce. Applied a developer version of jQuery, so I could see that it actually has an error on line 957, where it tries to append a child to a document. With further debugging around that, I found that the problem is with the code that moves the shortcuts link around. It moves the elements from one document to another. Previously it used to do markup copying and removal of the original element, but that was later changed to just transfer the element. While that works in Firefox, it does not work in Webkit, so we need to transfer the markup, as is. Therefore I moved back to similar code that was used before to copy the markup and remove the original element in the iframe. Works for me on Safari.
Comment #4
gábor hojtsyNote that ideally, we'd use outerHTML(), but that would need this to be added to drupal.js, which I believe we might be late to do given the code freeze. So I'm just copying the class and adding it on a div tag. Is not flexible for all kinds of theming obviously.
Comment #5
carlos8f commentedNice patch, I can confirm it fixes Safari and Chrome. Gotcha on #4.
Comment #6
ksenzeeThis could use a code comment, so it doesn't get changed back. I believe I changed it in the first place, and I'm quite capable of changing it again if I don't have a comment in there telling me not to. :)
Comment #7
gábor hojtsyUpdated patch with comments.
Comment #8
moshe weitzman commentedRTBC per #5
Comment #9
webchickGreat! Committed to HEAD, thanks!