Closed (duplicate)
Project:
Tagging
Version:
6.x-1.0-beta6
Component:
Javascript
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Dec 2009 at 15:17 UTC
Updated:
3 Jan 2010 at 16:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
janusman commentedHmm, in fact this would be a bug, because the help text directly states "Company, Inc." as an example =)
Comment #2
eugenmayer commentedThis aint a bug, as
"company, Inc." works, but this would become to tags "compony" and "Inc."
Comma ist the only seperator used and this is the complete common seperator in all systems.
I dont think tags need commas, as tags are NO sentences, and thats the only place where you need commas. So sorry, this is a nofix until you convince me not :)
Comment #3
eugenmayer commentedComment #4
eugenmayer commentedHi Janus,
the design seems to be broken in your installation
Is that the safari browser? Could you make screenshot of everthing including the suggestions?
Thanks!
Comment #5
eugenmayer commentedComment #6
eugenmayer commentedComment #7
eugenmayer commentedI actually changed the discription to be more precise
Comment #8
janusman commented(Just reinstalled the module, 6.x-1.0-beta6)
The attached screenshot might clarify things.
The problem is in this line in tagging.plugin.js :
tags = $(input_sel).not('.tag-processed').val().split(',');
which is overly simplifying things: Tags can be enclosed in quotes and have commas, spaces and other characets in them (see: http://api.drupal.org/api/function/drupal_explode_tags/6 )
This module, as is, forbids one to enter terms such as "I, Robot" which would be a valid single term in the regular Drupal autocomplete widget.
ANOTHER issue: enabling the module AFTER you already have such terms will also split your terms up incorrectly.
Comment #9
janusman commentedAlso, see http://drupal.org/node/559176 for how it was fixed in Active_tags module
Comment #10
eugenmayer commentedJanusman as this complicates the whole javascript part a lot, iam not gonna put this on hight priority. This will need a lot of tests to be properly supported.
Iam aware of the old "tagging style" where you could write down a whole sentence. But actually i dont think thats what a term should be, so i tend to downgrade this one to minor (as people need to use tags as tags like they are defined, not as "full text descriptions".
Feel free to provide patches if this one is urgent to you.
Comment #11
eugenmayer commentedThis is postponed until more needed or someone takes the work
Comment #12
eugenmayer commenteddublicate of http://drupal.org/node/673024