The Node picker button should be disabled when no text selection exists in the editor.

CommentFileSizeAuthor
#4 tinymce_node_picker-650284-link_title-6.x-2.0-beta4.patch1.96 KBhelmo

Comments

janusman’s picture

janusman commented

As an alternative, maybe the button could remain enabled when no text is selected so when a node is picked its title would inserted.

In fact this is how I expected the module to work, because I might not know what I'm looking for before I find it... maybe my use case is more common? =)

peter törnstrand’s picture

peter törnstrand commented

Ok, I'll hold off for a while and see if someone else seconds this.

helmo’s picture

helmo commented

I agree with janusman, using the node title would make for a nice default.

In fact I had a discussion about this yesterday, how irritating it can be to first have to type the link text.
It really depends on what you are used to, and what you are using it for.

PS: Great module.

helmo’s picture

helmo commented
StatusFileSize
new tinymce_node_picker-650284-link_title-6.x-2.0-beta4.patch1.96 KB

How about the attached patch?

It would probably also close #585450: Wrap link around text rather than using title from views listing

peter törnstrand’s picture

peter törnstrand commented
Status: Active » Patch (to be ported)

Great, will apply as soon as I can!

peter törnstrand’s picture

peter törnstrand commented
Status: Patch (to be ported) » Fixed
janusman’s picture

janusman commented

Yes! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.