This needs tests. Attached is a patch rolled with -w (no whitespace changes) to make the review easier.

CommentFileSizeAuthor
#5 drupal7.tgz.txt6.31 KBchx
#2 memcache.install.txt169 byteschx
#1 d7_memcache.patch13.57 KBchx
d7_memcache.patch13.57 KBchx
d7_review.txt9.27 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new d7_memcache.patch13.57 KB

d'oh clear was not 100% converted from table to bin.

chx’s picture

chx commented
StatusFileSize
new memcache.install.txt169 bytes

Install.

jeremy’s picture

jeremy commented

Cool! Subscribe.

litwol’s picture

litwol commented

I'm on this too.

chx’s picture

chx commented
StatusFileSize
new drupal7.tgz.txt6.31 KB

I snatched the core cache test thrown out isEmpty as we do not implement it changed the classnames, changed the parent setUp and then made it pass. The 0 byte module is important.

chx’s picture

chx commented

Note that memcache.inc has two return 0 which should really be return FALSE.

jeremy’s picture

jeremy commented
Status: Needs review » Active

CVS hates me today, but I have committed your patches -- thanks! I also minimally updated the README and INSTALL file, as the method for enabling memcache has changed a little.

I created a 7.x-dev snapshot which should appear soon.

Leaving this issue open, as we still need to port memcache.db.inc and memcache-session.inc.

jeremy’s picture

jeremy commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Reassigning to the 7.x-1.x-dev branch.

jeremy’s picture

jeremy commented
Status: Active » Fixed

The memcache-session.inc port effort can be found here:
#656838: [META] Port sessions to D7

If anyone uses the memcache.db.inc file, feel free to open a new issue for porting that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.