Just pressing ENTER at the end of the options line will make the module output invalid JavaScript. I spent some time figuring out this problem, because I'm used to put a newline at the end of textarea fields (an old sysadmin habit because some old Unix tools get very confused if the last line of a file is not a newline), but this is usually harmless on most Drupal textareas, and it's hard to tell a textarea has trailing newlines on a quick inspection.

Here's how the broken JavaScript looks like:

  addthis_options = 'favorites, email, digg, delicious, myspace, facebook, google, live, more
';

Sorry for not providing a patch, but the fix is straighforward: just change the settings field from textarea to textfield and it's done.

Comments

vesapalmu’s picture

Status: Active » Fixed

This has now been fixed by removing linefeeds in addthis_options. I don't want to make it a textfield since the list can be very long. The fix has been commited to D6-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.