Download & Extend

Overlay bug: admin links aren't transformed to overlay paths in IE/Opera

Project:Drupal core
Version:7.x-dev
Component:overlay.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)
Issue tags:overlay

Issue Summary

The javascript that transforms /admin path links into overlay paths (i.e., with #overlay=admin/path...) is broken in IE7, IE8, and Opera 9 and 10. I'm currently debugging this issue.

Comments

#1

Status:active» needs review

I found the cause to be that IE and Opera's implementation of the Link.pathname property lacks a leading slash. Here's a simple fix, adding the leading slash if it is absent.

AttachmentSizeStatusTest resultOperations
overlay-isadminlink.patch1012 bytesIdlePassed on all environments.View details

#2

adding tag

#3

Status:needs review» reviewed & tested by the community

I've verified the issue on Opers 10.10 / Mac and it does indeed happen to be there. The provided patch fixes this issue so that the admin paths are properly identified. Opera 10.10 still does not open any overlays, but it does not go to different admin pages either, since fragments are now properly used and updated (so we are one step closer to Opera support but not quite there yet).

#4

Status:reviewed & tested by the community» fixed

Well that definitely falls under the category of un-good.

Committed to HEAD. Thanks a lot, Carlos!

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here