Posted by kaakuu on December 4, 2009 at 5:06am
| Project: | Drag'n'Drop Uploads |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This is a wonderful nifty module for which many users will be so thankful.
However there is a critical problem when I try to work with certain themes other than Garland.
For example, with Pushbutton and some other themes there is "Validation Error"
Steps to reproduce
Fresh install of latest Drupal 6.14 and this module
Drag'n'Drop Uploads settings - Upload widget: File attachments
All other settings done properly
Enable Garland, enable Pushbutton
User chooses Garland - things work okay and as expected
User chooses Pushbutton as his theme
Drags image into textarea BUT the file name does not show up and in the attachment area there is "Validation Error" message - the image is not incorporated in the node.
Comments
#1
What browser(s) are you using?
I have tested this with a few themes, not Pushbutton, but haven't experienced this particular issue. Will test with Pushbutton and see what I can come up with.
Cheers,
Deciphered.
#2
Recommended browser. Firefox 3.6x plus.
As I already stated it seems to be some code that is incompatible with some themes - Pushbutton is an example. You can easily reproduce it. Problem is that if it does not work across themes, the module cannot function in these themes, which is critical for the sites having this theme already and wanting to use this module.
#3
I tested this with every default theme plus a few non-default themes with both Firefox 3.6 and Google Chrome and wasn't able to reproduce the issue.
There is no reason that it wouldn't work on other themes are there is nothing theme specific, the selectors are based on the FAPI elements, so if it works in one theme it should work in another.
If you can give me more information, screenshots, anything I'll continue to try to reproduce the issue.
It is possible, unlikely but possible, that the version I am testing with may have inadvertently fixed the issue, but I really doubt that. However I will try to get a new development version out ASAP.
Cheers,
Deciphered.
#4
I am having a similar problem, I spent all day trying to get this module to work. I saw this thread and switched themes and the module works great with garland. Here is the theme that I use on my sites as a admin theme.
I was only having success with Firefox 3.6 and then only some times. I tested Chrome Mac 4.0.249.30, Safari Mac 4.0.4 and they didn't work with this theme set as Admin and used for content editing.
I was never able to get it working in FF 3.5.5 using the WYSIWYG with either this theme or Garland, but it has been working without the WYSIWYG.
#5
Hi jrglasgow,
I will give it a test and see what I can do, but I won't have access to my Mac until the end of the day (8 hours from now) so I won't be able to completely confirm the issue.
As for Firefox 3.5.5, it requires Google Gears to work, which requires that you both have the gears_init.js file in the module directory (instructions on project page and in README.TXT) and also have the Google Gears extension for your browser installed (visit http://gears.google.com).
Let me know if that helps.
Cheers,
Deciphered.
#6
Deciphered,
I have Google Gears installed as you say in #5, and Firefox 3.5.5 works without the WYSIWYG, but not with.
#7
I have also noticed that Firefox 3.5.5 doesn't work with either WYSIWYG on you demo site, though it does work with the plain text demo.
#8
jrglasgow,
Yes, you are correct, Google Gears does not work with the WYSIWYG method. This is a known issue, which may not ever be fixed due to Googles announcement to discontinue work on Google Gears. I will however continue to attempt to discover a workaround for the issue.
One thing to note is that the files are being uploaded, it's only the xhr.onstatechange event that isn't being fired hence the lack of post-upload behaviors.
Any further discussion on this topic belongs in a new issue so as to keep this issue on topic.
Cheers,
Deciphered.
#9
Issue confirmed, seems to be restricted to the Safari/Chrome method of uploading.
Looking into the issue.
Cheers,
Deciphered.
#10
jrglasgow,
Simple fix to this issue, appears to be some weird conflict with css 'em' values when using this theme (and possibly others?), simple fix:
Change line #23 of dragndrop_uploads.css from:
font-size: 100em;to:
font-size: 200px;I know the values aren't equal conversions, but it's not about the specific size, just has to be huge for the Safari/Chrome upload trick.
Let me know how that goes for you, code will be committed within the next 24hours pending no conflicts.
Cheers,
Deciphered.
#11
Committed.
Cheers,
Deciphered.
#12