Some sites don't use titles for their comments. And without a title, there's no link in the results.

CommentFileSizeAuthor
#4 solr_comments_escaped_tags4.patch1.05 KBkcoop
#3 solr_comments_escaped_tags3.patch1.85 KBkcoop
#2 solr_comments_escaped_tags2.patch1.85 KBkcoop
solr_comments_title.patch1.04 KBkcoop

Comments

robertdouglass’s picture

robertdouglass commented
Status: Active » Fixed

Rearranged it just a bit:

-    $document->title = apachesolr_clean_text($comment->subject);
+    $title = empty($comment->subject) ? $comment->title : $node->subject;
+    $document->title = apachesolr_clean_text($title);

Committed to 6.2. Thanks!

kcoop’s picture

kcoop commented
StatusFileSize
new solr_comments_escaped_tags2.patch1.85 KB

You undoubtedly meant this:

$title = empty($comment->subject) ? $comment->subject : $node->title;
kcoop’s picture

kcoop commented
StatusFileSize
new solr_comments_escaped_tags3.patch1.85 KB

Er... rather, this. :-)

$title = empty($comment->subject) ? $node->title : $comment->subject;
kcoop’s picture

kcoop commented
StatusFileSize
new solr_comments_escaped_tags4.patch1.05 KB

Doh! It's just not my night. There was some cruft in that patch. Still learning this cvs thing...

dakku’s picture

dakku commented
Status: Fixed » Reviewed & tested by the community

Hi,
The patch by kcoop seems to fix the issue, nice typo Rob.. lol
Can this patch be committed please?

robertdouglass’s picture

robertdouglass commented
Status: Reviewed & tested by the community » Fixed

o mai gawd... did I really do that?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.