This is a great module, and I'm very impressed with the direction of Drupal especially when considering this in coordination with features and some others. A small enhancement request is that drush_make should support applying local patches, not only downloading new files. I'd also like to see the ability to have these patch files applied from either an absolute path or a path relative to Drupal's base_path. For now I'll do this within my own deployment script, and if I get around to it I'll contribute this myself.

Comments

acrollet’s picture

acrollet commented
Version: 6.x-2.0-beta5 » 6.x-2.x-dev

seconded - this is fairly important for those of us leveraging drush_make for custom distros. Also, in somewhat the same way that drush_make can find and parse a makefile that is included in a profile, it would be nice to have a shorthand syntax that could specify a patch included with a profile. To be totally clear:

Our main makefile specifies an svn repo from which to download a profile:

projects[cws_d6][type] = "profile"
projects[cws_d6][download][type] = "svn"
projects[cws_d6][download][url] = "file:///.../cws_d6"
projects[cws_d6][download][branch] = "trunk"

Within that directory, there is an installation profile, a makefile, and a couple of patches. It would be nice to be able to specify a patch in the makefile like so:

projects[drupal][patch][] = "htaccess.patch"

or perhaps profile_name/patch, i.e.:

projects[drupal][patch][] = "cws_d6/htaccess.patch"

(though that's close to the same thing as a relative path from the base_path)

If given guidance as to where to look, I'd be happy to contribute a patch for drush_make.

thanks for the consideration.

dmitrig01’s picture

dmitrig01 commented

DrushMakeProject::applyPatches and drush_make_get_remote_file

thebuckst0p’s picture

thebuckst0p commented

I "third" this request. Can I take dmitrig01's comment to mean it's being worked on?

dmitrig01’s picture

dmitrig01 commented
Status: Active » Fixed

it works in head

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.