OK so I activated this module, set up a "General Newsletter" list on MailChimp. My "General Newsletter" list shows up on the Drupal MailChimp admin screen, so I check the Anonymous and Authenticated roles so everyone can signup. Then I go the the Blocks and place the Mailchimp Subscription Form block in the left sidebar.

Problem: for anonymous users it renders the line "Subscribe to the General Newsletter newsletter" within a "Legend" tag of a "Fieldset" and there are known issues with the text in legend tags not wrapping on whitespace. In FF3 it is extending the fieldset outside of the container "block" div's and in IE8 it just extends the text outside the fieldset. It does not wrap on the whitespace in either case.

Explicitly forcing: legend {white-space: nowrap;} works for FF but not IE. I apologize if this issue has been dealt with before and I could not find the answer. It seems to me like this would be a very common problem.

Thanks for the great module in any case!

Comments

levelos’s picture

levelos commented
Status: Active » Closed (won't fix)

Not module specific. Either change the label through form_alter or using translation and/or use the page rather than the block.

icenogle’s picture

icenogle commented
Status: Closed (won't fix) » Active

Do you really think this an appropriate response to a legitimate issue? I don't. I came here with exactly the same problem.

First, not everything is a "newsletter." Second, if you can't make a block work in all appropriate cases, that's a bug.

If you don't see it as a priority to fix the bug, leave it open, and maybe someone else will fix it.

levelos’s picture

levelos commented

Well, I'm not sure about my response, but I definitely find yours very inappropriate. If you have something helpful to contribute, like actual code, advice, or suggestions, that would be most welcome. Otherwise, it's just distracting noise.

I'm fine leaving the issue open, although I like the issue queue kept clean in my modules, and this is not something I will work on, which is why the status was "won't fix", which makes sense to me.

icenogle’s picture

icenogle commented

I am, in fact, working on a solution. I don't know if I'll get there, but if I don't perhaps someone else will. Leaving it open means, 'Yes, this is an issue.' 'Won't Fix' implies that it isn't. Drupal is a community. Let the community figure out a solution if you don't have one. Having a block that is dysfunctional is an issue. Sign-ups for tips, tricks, and newsletters are sensitive to ease of use. Making people go to another page to do it is often a bridge too far. The block needs to work. Status classification is constructive advice. Encouraging other people to fix is constructive advice. Experience about what makes this whole module potentially useful or not is constructive advice. Better to take constructive advice than be offended by it. The only legitimate way to keep your issue queue clean is to fix bugs, rather than just taking them out of the queue.

gregoryshearer’s picture

gregoryshearer commented

Wow let's not fight about it! I see both your points. LouBabe is correct that the fieldset legend bug is not specific to this module, but the fact that this form is implemented in a Block means that this issue will be a problem every time someones does so. Icenogle also make several good points, especially the fact that the "Subscribe to the XXXXXXXX newsletter" part seems to be hardcoded and not all lists are accurately described as a "newsletter".

It would be really nice if this line could be edited or overridden on the block configuration page and (IMO of course) implementing it as a fieldset legend in the blocks view is a bad technique b/c of the known issues. I can see why you'd want to use it on page views to potentially take advantage of collapsible fieldsets though.

My partial work-around at this point is to suppress the display of the legend in css (works FF3.5 and IE8, not IE7):

#mailchimp-subscribe-anon-form legend { display: none; }

But the best I've got for IE7 is to clip the overflow of the fieldset:

#mailchimp-subscribe-anon-form fieldset { overflow:hidden; }

It's still there, so this is less than ideal, but does not spill out of the block.

Thanks again for the great module!

levelos’s picture

levelos commented
Status: Active » Fixed

Alright gang, I've removed the fieldset from all newslettter forms except on the account edit and registration screens. Each newsletter is instead wrapped in a div which can be styled as desired. Current in dev release, but a new RC coming soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Closed (fixed) » Needs review

loubabe,

Sorry to open this again, but this seems to be a problem with Firefox and IE that must be solved with CSS, with some help from the module.

See http://www.communitymx.com/blog/index.cfm?newsid=882&blogger=15 and http://www.communitymx.com/blog/index.cfm?newsid=923 for more details.

From the point of view from the module, the following patch should be applied:

Index: mailchimp.module
===================================================================
--- mailchimp.module    (revision 315)
+++ mailchimp.module    (working copy)
@@ -416,7 +416,7 @@
   foreach ($lists as $list) {
     $form['mailchimp_lists'][$list->id] = array(
       '#type' => 'fieldset',
-      '#title' => t('@name', array('@name' => $list->name)),
+      '#title' => '<span>'. t('@name', array('@name' => $list->name)) .'</span>' ,
       '#description' => t('@desc', array('@desc' => $list->description)),
       '#collapsible' => TRUE,
       '#collapsed' => FALSE,

Then, the theme must provide the following CSS:

fieldset legend {
  display: block;
  width: _nnn_px;
  white-space: normal;
}
nrackleff’s picture

nrackleff commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

“And now our watch [for support of the 6.x version of the MailChimp module] has ended…” With the end of Drupal 6 support, I’m sad to say we too must turn the page.

Fret not! The 7.x-4.x and 8.x versions come highly recommended. Both are using Mailchimp’s new API 3.0 and are being actively maintained. “What is dead may never die, but rises again, harder and stronger!”