I don't really want to enable the contact module if I don't need to. I understand the example will not work but if using it for another module it shouldn't be needed; also the read me says jquery update is required but it is not in the dependencies.

I'm not sure if this is a feature request or bug report due to not knowing if there's some random contact module code needed for form_controller, but I doubt it.

I can make a patch if desired, but I'm being a bit lazy A(utomatic)T(eller)M(achine).

CommentFileSizeAuthor
#7 651608_form_controller_split.patch8.54 KBhefox
#6 651608_form_controller_readme.patch405 byteshefox
#5 651608_form_controller_readme.patch453 byteshefox
#4 form_controller_split.patch8.51 KBjcmarco
#1 651608-formcontroller-dependency-D6.patch530 bytesdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 651608-formcontroller-dependency-D6.patch530 bytes

Simple 'nuff.

mrfelton’s picture

mrfelton commented

+1

dboulet’s picture

dboulet commented

+1 from me too, especially since this module is now required to have a UI to control vertical tabs. I don't want to have to enable the contact module every time that I want to use VT.

jcmarco’s picture

jcmarco commented
StatusFileSize
new form_controller_split.patch8.51 KB

Create a new demo module with the contact sample as it is done with other modules.

hefox’s picture

hefox commented
Title: Remove contact module dependecy, add jquery update » Remove contact module dependecy, remove jquery update from readme
StatusFileSize
new 651608_form_controller_readme.patch453 bytes

Read me should be updated to reflect the lack of needing to use jquery update so people that actually read it don't get confused.

Patch attached (not including the contact module additions since they're not completely related). Should I make a new issue for this?

hefox’s picture

hefox commented
StatusFileSize
new 651608_form_controller_readme.patch405 bytes

Patch done from wrong directory; updated.

hefox’s picture

hefox commented
StatusFileSize
new 651608_form_controller_split.patch8.54 KB

(Review for #4 patch, working as far as the main module). Considering there are two modules, should the package be changed to "Form Controller"? Devolpment seems to be an inaccurate pachage for it also.

Here's the patch manually edited to add in the different package name (forgot to commit some previous change, so svn diff wouldn't produce the right output so didn't feel like bothering with redoing the patch via diffing).

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Project: Form controller » Form
Version: 6.x-2.x-dev » 6.x-1.x-dev
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Category: feature » task
Status: Needs review » Needs work

The example implementation needs to move into a form__test.module in the sub-directory tests/. Please note the double underscore.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Remove contact module dependecy, remove jquery update from readme » Remove Contact module dependency

Better title.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Committed to CVS: http://drupal.org/cvs?commit=299408

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.