There is a simple bug in menu_tree_output() that accidentally resets the 'localized_options' array before it gets to the l() function. This currently prevents all title attributes, query arrays, etc from rendering in the resulting menu links.

CommentFileSizeAuthor
#7 menu-link-options3.patch2.13 KBcarlos8f
#5 menu-link-options2.patch2.13 KBcarlos8f
#3 menu-link-options.patch2.13 KBcarlos8f
localized-options-fix.patch925 bytescarlos8f

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

good catch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

Can we get a test for this?

carlos8f’s picture

carlos8f commented
Status: Needs work » Needs review
StatusFileSize
new menu-link-options.patch2.13 KB

Added a test, which tests for the title attribute and query string on a rendered menu link. Verified that the test fails on HEAD, but passes with the fix.

Status: Needs review » Needs work

The last submitted patch failed testing.

carlos8f’s picture

carlos8f commented
Status: Needs work » Needs review
StatusFileSize
new menu-link-options2.patch2.13 KB

#3 passed in my environment. Tweaking to see if this passes the testbot.

Status: Needs review » Needs work

The last submitted patch failed testing.

carlos8f’s picture

carlos8f commented
Status: Needs work » Needs review
StatusFileSize
new menu-link-options3.patch2.13 KB

I think the fail happened because testbot's simpletest must have clean URL's off, whereas my simpletest has them on.

grndlvl’s picture

grndlvl commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Excellent. Thanks much, carlos!

Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Needs tests

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs tests

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.