This is driving me literally to the brink of insanity atm:

MARGH!

CommentFileSizeAuthor
#11 651810_typo.patch518 bytesksenzee
#6 overlay_force_reload.patch688 bytesaspilicious

Comments

casey’s picture

casey commented

Reminder to post a patch for this. Could use same approach as #666974: Open admin links without overlay using CTRL+Click.

casey’s picture

casey commented

I'll write a patch after #668104: Make overlay respect other click handlers is committed.

Anonymous’s picture

Anonymous (not verified) commented

I believe this is the same issue. If it is not I can create a new one.

When administering Content Types in Firefox 3.5.7.....

If you click Manage Fields tab to create a new field, save your field, and are back on the edit tab, you can't click on the Manage Fields tab again.

You can, however, click on Manage Display which seems to break the spell so you can then click on Manage Fields again.

kiphaas7’s picture

kiphaas7 commented

Change:

Drupal.overlay.redirect = function (link) {
  if (link.indexOf('http') != 0 && link.indexOf('https') != 0) {
    var absolute = location.href.match(/https?:\/\/[^\/]*/)[0];
    link = absolute + link;
  }
  location.href = link;
  return true;
};

To:

Drupal.overlay.redirect = function (link) {
  if (link.indexOf('http') != 0 && link.indexOf('https') != 0) {
    var absolute = location.href.match(/https?:\/\/[^\/]*/)[0];
    link = absolute + link;
  }

  // If the link is already open, force the haschange event.
  if (location.href == link) {
    $(window).trigger('hashchange.overlay-event');
  }

  location.href = link;
  return true;
};
kiphaas7’s picture

kiphaas7 commented
Status: Active » Needs work

Setting to "needs work" since my epic fail loan laptop still doesn't have patch/diff installed. MAARGH!

aspilicious’s picture

aspilicious commented
StatusFileSize
new overlay_force_reload.patch688 bytes

Maybe I can help...

aspilicious’s picture

aspilicious commented
Status: Needs work » Needs review

run bot!

kiphaas7’s picture

kiphaas7 commented

Looks good, but then, it's kinda my own patch :P.

Please review this patch, it's one hell of an annoying bug...

casey’s picture

casey commented
Status: Needs review » Reviewed & tested by the community

Fine by me. Webchick started this issue so this'll have a quick commit ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

OH THANK THE HEAVENS.

Committed to HEAD! :D

ksenzee’s picture

ksenzee
she/her
commented
Status: Fixed » Needs review
StatusFileSize
new 651810_typo.patch518 bytes

Typo in code comment, plus a bit more explanation of what's actually going on.

casey’s picture

casey commented
Status: Needs review » Reviewed & tested by the community

Definitely an improvement.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed.

kiphaas7’s picture

kiphaas7 commented

Eck, stupid mistake. Thanks for finding that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.